From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next 0/5] mptcp: add SOL_MPTCP getsockopt support
Date: Thu, 12 Aug 2021 13:07:49 +0200 [thread overview]
Message-ID: <20210812110749.GY607@breakpoint.cc> (raw)
In-Reply-To: <0a040c70d57ce758a37f92cb214ee332656b3057.camel@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> > 8 files changed, 869 insertions(+), 29 deletions(-)
> > create mode 100644 tools/testing/selftests/net/mptcp/mptcp_sockopt.c
>
> The patches LGTM! I have just a couple of minor curiosity.
>
> In some helper the argument that carries the option length from user
> space is named '_u_optlen', any special reason for that? Encoding the
> argument attribute into the user name looks really win32 style from the
> early 2000, afaik ;))) [no offense intended!!!]
Ok, I'll rename it to 'int __user *optlen' in v2.
> I don't see how the mptcp_subflow_addrs is going to change/increase the
> size with time... do you have some possible ideas/guess?
No idea. IPv8? I added struct sockaddr_storage into the union so it will
hopefully be enough but who knows, this API might well live on for decades
and I'd rather have a small back door that allows to increase this if
needed.
prev parent reply other threads:[~2021-08-12 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 13:15 [PATCH mptcp-next 0/5] mptcp: add SOL_MPTCP getsockopt support Florian Westphal
2021-08-11 13:15 ` [PATCH mptcp-next 1/5] mptcp: add new mptcp_fill_diag helper Florian Westphal
2021-08-11 13:15 ` [PATCH mptcp-next 2/5] mptcp: add MPTCP_INFO getsockopt Florian Westphal
2021-08-12 16:46 ` Mat Martineau
2021-08-11 13:15 ` [PATCH mptcp-next 3/5] mptcp: add MPTCP_TCPINFO getsockopt support Florian Westphal
2021-08-12 17:03 ` Mat Martineau
2021-08-12 18:41 ` Florian Westphal
2021-08-11 13:15 ` [PATCH mptcp-next 4/5] mptcp: add MPTCP_SUBFLOW_ADDRS " Florian Westphal
2021-08-11 21:18 ` kernel test robot
2021-08-12 3:02 ` kernel test robot
2021-08-11 13:15 ` [PATCH mptcp-next 5/5] selftests: mptcp: add mptcp getsockopt test cases Florian Westphal
2021-08-12 11:14 ` Paolo Abeni
2021-08-12 11:28 ` Florian Westphal
2021-08-12 10:58 ` [PATCH mptcp-next 0/5] mptcp: add SOL_MPTCP getsockopt support Paolo Abeni
2021-08-12 11:07 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812110749.GY607@breakpoint.cc \
--to=fw@strlen.de \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox