From: Florian Westphal <fw@strlen.de>
To: <mptcp@lists.linux.dev>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH mptcp-next v3 0/5] mptcp: add SOL_MPTCP getsockopt support
Date: Wed, 18 Aug 2021 12:27:51 +0200 [thread overview]
Message-ID: <20210818102756.30734-1-fw@strlen.de> (raw)
Changes in v3:
- address comments from Mat.
This only affects selftest program (init 'fd' to -1).
Other than that, the only changes are in commit messages or
re-format of code (reverse xmas).
Changes in v2:
- move #define to start of file (Mat)
- refer to '"multipath-tcp.org"', not mptcp.org (Mat)
- use __kernel_sa_family_t in uapi header (test robot)
- add test cases with invalid inputs (Paolo)
- avoid duplicate mptcp_sockopt.h in Makefile (Paolo)
- remove _u_optlen (Paolo)
original cover letter:
This adds the MPTCP_INFO, MPTCP_TCPINFO and MPTCP_SUBFLOW_ADDRS
mptcp getsockopt optnames.
MPTCP_INFO exposes the mptcp_info struct as an alternative to the
existing netlink diag interface.
MPTCP_TCPINFO exposes the tcp_info struct.
Unlike SOL_TCP/TCP_INFO, this returns one struct for each active
subflow.
MPTCP_SUBFLOW_ADDRS allows userspace to discover the ip addresses/ports
used by the local and remote endpoints, one for each active tcp subflow.
MPTCP_TCPINFO and MPTCP_SUBFLOW_ADDRS share the same meta-header that
needs to be pre-filled by userspace with the size of the data structures
it expects. This is done to allow extension of the involved structs
later on, without breaking backwards compatibility.
The meta-structure can also be used to discover the required space
to obtain all information, as kernel will fill in the number of
active subflows even if there is not enough room for the requested info
itself.
More information is available in the individual patches.
Last patch adds test cases for the three optnames.
Florian Westphal (5):
mptcp: add new mptcp_fill_diag helper
mptcp: add MPTCP_INFO getsockopt
mptcp: add MPTCP_TCPINFO getsockopt support
mptcp: add MPTCP_SUBFLOW_ADDRS getsockopt support
selftests: mptcp: add mptcp getsockopt test cases
include/linux/socket.h | 1 +
include/net/mptcp.h | 4 +
include/uapi/linux/mptcp.h | 29 +
net/mptcp/mptcp_diag.c | 26 +-
net/mptcp/sockopt.c | 276 ++++++++
tools/testing/selftests/net/mptcp/Makefile | 2 +-
.../selftests/net/mptcp/mptcp_sockopt.c | 644 ++++++++++++++++++
.../selftests/net/mptcp/mptcp_sockopt.sh | 31 +-
8 files changed, 985 insertions(+), 28 deletions(-)
create mode 100644 tools/testing/selftests/net/mptcp/mptcp_sockopt.c
--
2.31.1
next reply other threads:[~2021-08-18 10:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 10:27 Florian Westphal [this message]
2021-08-18 10:27 ` [PATCH v3 mptcp-next 1/5] mptcp: add new mptcp_fill_diag helper Florian Westphal
2021-08-18 10:27 ` [PATCH v3 mptcp-next 2/5] mptcp: add MPTCP_INFO getsockopt Florian Westphal
2021-08-18 10:27 ` [PATCH v3 mptcp-next 3/5] mptcp: add MPTCP_TCPINFO getsockopt support Florian Westphal
2021-08-18 10:27 ` [PATCH v3 mptcp-next 4/5] mptcp: add MPTCP_SUBFLOW_ADDRS " Florian Westphal
2021-08-30 4:18 ` Geliang Tang
2021-08-18 10:27 ` [PATCH v3 mptcp-next 5/5] selftests: mptcp: add mptcp getsockopt test cases Florian Westphal
2021-08-18 16:59 ` [PATCH mptcp-next v3 0/5] mptcp: add SOL_MPTCP getsockopt support Mat Martineau
2021-08-18 19:17 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818102756.30734-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox