From: Florian Westphal <fw@strlen.de>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp] mptcp: don't return sockets in foreign netns
Date: Thu, 16 Sep 2021 12:07:04 +0200 [thread overview]
Message-ID: <20210916100704.GB20414@breakpoint.cc> (raw)
In-Reply-To: <42126ef3-b46d-27ef-64d7-7a257275e188@linux.intel.com>
Mat Martineau <mathew.j.martineau@linux.intel.com> wrote:
>
> On Wed, 15 Sep 2021, Florian Westphal wrote:
>
> > mptcp_token_get_sock() may return a mptcp socket that is in
> > a different net namespace than the socket that received the token value.
> >
> > The mptcp syncookie code path had an explicit check for this,
> > this moves the test intp mptcp_token_get_sock() function.
> >
> > Eventually token.c should be converted to pernet storage, but
> > such change is not suitable for net tree.
> >
> > Signed-off-by: Florian Westphal <fw@strlen.de>
>
> For the net tree, would need a Fixes tag. How about:
>
> Fixes: 2c5ebd001d4f0 ("mptcp: refactor token container")
>
> mptcp_token_get_sock() was originally introduced in f296234c98a8f, but the
> changes here would only apply to Paolo's refactor and KUNIT tests.
Yep, f296234c98a8f is 'more correct' (day 0), but I'm fine with using
2c5ebd001d4f0 instead.
Thanks for reviewing.
next prev parent reply other threads:[~2021-09-16 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 12:11 [PATCH mptcp] mptcp: don't return sockets in foreign netns Florian Westphal
2021-09-15 23:28 ` Mat Martineau
2021-09-16 10:07 ` Florian Westphal [this message]
2021-09-16 16:21 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916100704.GB20414@breakpoint.cc \
--to=fw@strlen.de \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox