From: Florian Westphal <fw@strlen.de>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next 2/3] selftests: mptcp: add TCP_INQ support
Date: Wed, 10 Nov 2021 11:18:23 +0100 [thread overview]
Message-ID: <20211110101823.GF16363@breakpoint.cc> (raw)
In-Reply-To: <634cff10-1c91-2a68-74cd-3c48da807528@linux.intel.com>
Mat Martineau <mathew.j.martineau@linux.intel.com> wrote:
> On Mon, 8 Nov 2021, Florian Westphal wrote:
>
> > Do checks on the returned inq counter.
> > Fail on:
> > 1. Huge value (>= 1 megabyte, test case files are 1 MB)
> > 2. last hint larger than returned bytes when read was short
> > 3. erroenous indication of EOF.
> >
> > 3) happens when a hint of X bytes reads X-1 on next call
> > but next recvmsg returns more data (instead of EOF).
> >
>
> Is it possible to do a more deterministic test? Like: one peer sends X
> bytes, other peer waits and then reads X-Y bytes, then checks that the inq
> value is Y?
Ok, will add a new mptcp_inq test instead of this one.
next prev parent reply other threads:[~2021-11-10 10:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 10:57 [PATCH mptcp-next 0/3] support for setsockopt(TCP_INQ) Florian Westphal
2021-11-08 10:57 ` [PATCH mptcp-next 1/3] mptcp: add TCP_INQ cmsg support Florian Westphal
2021-11-10 1:11 ` Mat Martineau
2021-11-10 10:17 ` Florian Westphal
2021-11-10 19:13 ` Mat Martineau
2021-11-10 19:35 ` Mat Martineau
2021-11-10 23:09 ` Florian Westphal
2021-11-11 0:05 ` Mat Martineau
2021-11-11 10:48 ` Paolo Abeni
2021-11-08 10:57 ` [PATCH mptcp-next 2/3] selftests: mptcp: add TCP_INQ support Florian Westphal
2021-11-10 1:18 ` Mat Martineau
2021-11-10 10:18 ` Florian Westphal [this message]
2021-11-08 10:57 ` [PATCH mptcp-next 3/3] mptcp: add SIOCINQ, OUTQ and OUTQNSD ioctls Florian Westphal
2021-11-08 17:08 ` Matthieu Baerts
2021-11-10 8:48 ` Paolo Abeni
2021-11-10 8:53 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110101823.GF16363@breakpoint.cc \
--to=fw@strlen.de \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox