MPTCP Linux Development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Geliang Tang <geliang.tang@suse.com>, mptcp@lists.linux.dev
Cc: kbuild-all@lists.01.org, Geliang Tang <geliang.tang@suse.com>
Subject: Re: [PATCH mptcp-next v16 6/8] mptcp: add bpf_mptcp_sched_ops
Date: Wed, 27 Apr 2022 21:29:15 +0800	[thread overview]
Message-ID: <202204272125.AiqJUAjR-lkp@intel.com> (raw)
In-Reply-To: <8ac278434203662add804d00e007c2cb2b6f52e4.1651024344.git.geliang.tang@suse.com>

Hi Geliang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mptcp/export]
[cannot apply to bpf-next/master bpf/master linus/master v5.18-rc4 next-20220427]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Geliang-Tang/BPF-packet-scheduler/20220427-095943
base:   https://github.com/multipath-tcp/mptcp_net-next.git export
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220427/202204272125.AiqJUAjR-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
net/mptcp/bpf.c:148 bpf_mptcp_sched_init() warn: unsigned 'mptcp_sched_id' is never less than zero.

vim +/mptcp_sched_id +148 net/mptcp/bpf.c

   143	
   144	static int bpf_mptcp_sched_init(struct btf *btf)
   145	{
   146		mptcp_sched_id = btf_find_by_name_kind(btf, "mptcp_sched_data",
   147						       BTF_KIND_STRUCT);
 > 148		if (mptcp_sched_id < 0)
   149			return -EINVAL;
   150		mptcp_sched_type = btf_type_by_id(btf, mptcp_sched_id);
   151	
   152		return 0;
   153	}
   154	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

  reply	other threads:[~2022-04-27 13:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  1:56 [PATCH mptcp-next v16 0/8] BPF packet scheduler Geliang Tang
2022-04-27  1:56 ` [PATCH mptcp-next v16 1/8] mptcp: add struct mptcp_sched_ops Geliang Tang
2022-04-27  1:56 ` [PATCH mptcp-next v16 2/8] mptcp: register default scheduler Geliang Tang
2022-04-27  1:56 ` [PATCH mptcp-next v16 3/8] mptcp: add a new sysctl scheduler Geliang Tang
2022-04-27  1:56 ` [PATCH mptcp-next v16 4/8] mptcp: add sched in mptcp_sock Geliang Tang
2022-04-27  1:56 ` [PATCH mptcp-next v16 5/8] mptcp: add get_subflow wrapper Geliang Tang
2022-04-27  8:27   ` Paolo Abeni
2022-04-27  8:56     ` Paolo Abeni
2022-04-27 14:34     ` Geliang Tang
2022-04-27 16:53       ` Matthieu Baerts
2022-04-27  1:56 ` [PATCH mptcp-next v16 6/8] mptcp: add bpf_mptcp_sched_ops Geliang Tang
2022-04-27 13:29   ` kernel test robot [this message]
2022-04-27  1:56 ` [PATCH mptcp-next v16 7/8] selftests: bpf: add bpf_first scheduler Geliang Tang
2022-04-27  1:56 ` [PATCH mptcp-next v16 8/8] selftests: bpf: add bpf_first test Geliang Tang
2022-04-27  3:30   ` selftests: bpf: add bpf_first test: Tests Results MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204272125.AiqJUAjR-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=geliang.tang@suse.com \
    --cc=kbuild-all@lists.01.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox