From: Florian Westphal <fw@strlen.de>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] selftests: mptcp: add TCP_DEFER test case
Date: Tue, 3 May 2022 23:32:27 +0200 [thread overview]
Message-ID: <20220503213227.GC21053@breakpoint.cc> (raw)
In-Reply-To: <403af1b2-b34d-45f-c53-ae2f1e18225@linux.intel.com>
Mat Martineau <mathew.j.martineau@linux.intel.com> wrote:
> On Mon, 2 May 2022, Florian Westphal wrote:
>
> > Check that value x can be set and retrieved.
> >
>
> Hi Florian -
>
> I see the same error in this test with both my local test VM and when
> running Matthieu's CI script on a different machine:
>
> # mptcp_sockopt: mptcp_sockopt.c:150: check_tcp_defer: Assertion `rv == value' failed.
> # mptcp_sockopt: mptcp_sockopt.c:765: main: Assertion `e1 == 4' failed.
seems like fix is to remove this test, kernel xlates value to
number-of-retrainsmits so set and get may return different values.
next prev parent reply other threads:[~2022-05-03 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 16:36 [PATCH mptcp-next] selftests: mptcp: add TCP_DEFER test case Florian Westphal
2022-05-02 18:14 ` selftests: mptcp: add TCP_DEFER test case: Tests Results MPTCP CI
2022-05-03 21:22 ` [PATCH mptcp-next] selftests: mptcp: add TCP_DEFER test case Mat Martineau
2022-05-03 21:32 ` Florian Westphal [this message]
2022-05-05 0:04 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503213227.GC21053@breakpoint.cc \
--to=fw@strlen.de \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox