Re: [PATCH mptcp-next] Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups

[Geliang Tang <geliang.tang@suse.com>]

On Wed, May 04, 2022 at 07:44:24PM +0800, Geliang Tang wrote:
> Two small cleanups for MP_FAIL reset test case:
> 
> Reduce the test files size from 1024 to 128, to make the test faster.

The original commit log needs to update too:

 1024KB -> 128KB

'''
Add the multiple subflows test case for MP_FAIL, to test the MP_FAIL
reset case. Use the test_linkfail value to make 128KB test files.

...
...
'''

> With Paolo's fix [2] for MP_FAIL test-case, the test becomes very slow.
> 
> Drop '+'s passed to chk_csum_nr, with Paolo's fix [1] for act_pedit, no
> extra checksum failures now, no need to add '+'s anymore.
> 
> Depends on Paolo's commits:
> [1] net/sched: act_pedit: really ensure the skb is writable
> [2] selftests: mptcp: fix MP_FAIL test-case
> 
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
>  tools/testing/selftests/net/mptcp/mptcp_join.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index a5e90532eaea..91c840ec91c8 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -2739,8 +2739,8 @@ fail_tests()
>  		pm_nl_set_limits $ns1 0 1
>  		pm_nl_set_limits $ns2 0 1
>  		pm_nl_add_endpoint $ns2 10.0.2.2 dev ns2eth2 flags subflow
> -		run_tests $ns1 $ns2 10.0.1.1 1024
> -		chk_join_nr 1 1 1 +1 +0 1 1 0 "$(pedit_action_pkts)"
> +		run_tests $ns1 $ns2 10.0.1.1 128
> +		chk_join_nr 1 1 1 1 0 1 1 0 "$(pedit_action_pkts)"
>  	fi
>  }
>  
> -- 
> 2.34.1
>