From: Florian Westphal <fw@strlen.de>
To: Geliang Tang <geliang.tang@suse.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v8 1/6] Squash to "mptcp: add get_subflow wrappers"
Date: Thu, 23 Jun 2022 14:03:21 +0200 [thread overview]
Message-ID: <20220623120321.GA21459@breakpoint.cc> (raw)
In-Reply-To: <a911f0b25336c9c4098daa4d58a1d8a2ee81213f.1655979747.git.geliang.tang@suse.com>
Geliang Tang <geliang.tang@suse.com> wrote:
> -struct sock *mptcp_sched_get_send(struct mptcp_sock *msk)
> +struct sock *mptcp_sched_get_send(struct mptcp_sock *msk, int *err)
> {
Why the extra *err?
Almost everyone else uses ERR_PTR, PTR_ERR, IS_ERR, etc. to return
the error code directly, why not follow that model?
next prev parent reply other threads:[~2022-06-23 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 10:50 [PATCH mptcp-next v8 0/6] BPF redundant scheduler Geliang Tang
2022-06-23 10:50 ` [PATCH mptcp-next v8 1/6] Squash to "mptcp: add get_subflow wrappers" Geliang Tang
2022-06-23 12:03 ` Florian Westphal [this message]
2022-06-23 10:50 ` [PATCH mptcp-next v8 2/6] mptcp: accept right edge of mapping validating Geliang Tang
2022-06-23 10:50 ` [PATCH mptcp-next v8 3/6] mptcp: redundant subflows push pending Geliang Tang
2022-06-23 10:50 ` [PATCH mptcp-next v8 4/6] mptcp: redundant subflows retrans support Geliang Tang
2022-06-23 10:50 ` [PATCH mptcp-next v8 5/6] selftests/bpf: Add bpf_red scheduler Geliang Tang
2022-06-23 10:50 ` [PATCH mptcp-next v8 6/6] selftests/bpf: Add bpf_red test Geliang Tang
2022-06-23 12:39 ` selftests/bpf: Add bpf_red test: Tests Results MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623120321.GA21459@breakpoint.cc \
--to=fw@strlen.de \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox