Re: [PATCH mptcp-next v19 0/9] BPF redundant scheduler, part 1

[Geliang Tang <geliang.tang@suse.com>]

On Tue, Nov 15, 2022 at 04:41:15PM -0800, Mat Martineau wrote:
> On Fri, 11 Nov 2022, Geliang Tang wrote:
> 
> > v19:
> > - update patch 1.
> > - split "BPF redundant scheduler" into two parts.
> > - rebased on "export/20221111T055536".
> > 
> 
> Thanks Geliang.
> 
> I think v19 (part 1) looks ok for the export branch. simult_flows.sh was
> slightly faster (small sample size :) ) on my VM, for what it's worth.
> 
> Looks like the first three patches go at the beginning of the "features
> net-next-next" section, correct?

Yes, the first two patches ("mptcp: refactor push_pending logic" and
"mptcp: drop last_snd and MPTCP_RESET_SCHEDULER") go at the beginning
of the "features net-next-next" section. But the third one "mptcp: add
sched_data_set_contexts helper" should be inserted between the commits
"mptcp: add scheduled in mptcp_subflow_context" and "bpf: Add
bpf_mptcp_sched_ops".

Thanks,
-Geliang

> 
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> 
> > Geliang Tang (9):
> >  mptcp: refactor push_pending logic
> >  mptcp: drop last_snd and MPTCP_RESET_SCHEDULER
> >  mptcp: add sched_data_set_contexts helper
> >  Squash to "mptcp: add struct mptcp_sched_ops"
> >  Squash to "bpf: Add bpf_mptcp_sched_ops"
> >  Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"
> >  Squash to "selftests/bpf: Add bpf_first scheduler"
> >  Squash to "selftests/bpf: Add bpf_bkup scheduler"
> >  Squash to "selftests/bpf: Add bpf_rr scheduler"
> > 
> > include/net/mptcp.h                           |   6 +-
> > net/mptcp/bpf.c                               |   1 +
> > net/mptcp/pm.c                                |   9 +-
> > net/mptcp/pm_netlink.c                        |   3 -
> > net/mptcp/protocol.c                          | 161 +++++++++---------
> > net/mptcp/protocol.h                          |   1 -
> > net/mptcp/sched.c                             |  21 ++-
> > tools/testing/selftests/bpf/bpf_tcp_helpers.h |   8 +-
> > .../selftests/bpf/progs/mptcp_bpf_bkup.c      |  10 +-
> > .../selftests/bpf/progs/mptcp_bpf_first.c     |  10 +-
> > .../selftests/bpf/progs/mptcp_bpf_rr.c        |  10 +-
> > 11 files changed, 143 insertions(+), 97 deletions(-)
> > 
> > -- 
> > 2.35.3
> > 
> > 
> > 
> 
> --
> Mat Martineau
> Intel