Re: [PATCH mptcp-next v5 0/4] add pm listener events

[Geliang Tang <geliang.tang@suse.com>]

On Thu, Nov 17, 2022 at 05:44:10PM -0800, Mat Martineau wrote:
> On Thu, 17 Nov 2022, Geliang Tang wrote:
> 
> > v5:
> > - use GFP_KERNEL instead of GFP_ATOMIC in patch 1.
> > - add the listener event checking in the existing test in patch 4.
> > - update subjects and commit logs.
> > 
> 
> v5 looks good to me (one minor commit message change noted on patch 3, if
> it's ok with Geliang):

Thanks, I agree. Please help me update this commit message when merging
it.

-Geliang

> 
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> 
> > v4:
> > - split the selftests into two patches.
> > - do some cleanups.
> > 
> > v3:
> > - add selftests.
> > 
> > v2:
> > - send created event from mptcp_listen.
> > - add a new patch, use entry->lsk directly.
> > 
> > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/313
> > 
> > Geliang Tang (4):
> >  mptcp: add pm listener events
> >  selftests: mptcp: enhance userspace pm tests
> >  selftests: mptcp: listener test for userspace PM
> >  selftests: mptcp: listener test for in-kernel PM
> > 
> > include/uapi/linux/mptcp.h                    |  9 ++
> > net/mptcp/pm_netlink.c                        | 57 ++++++++++++
> > net/mptcp/protocol.c                          |  3 +
> > net/mptcp/protocol.h                          |  2 +
> > .../testing/selftests/net/mptcp/mptcp_join.sh | 65 +++++++++++++-
> > .../selftests/net/mptcp/userspace_pm.sh       | 89 ++++++++++++++++++-
> > 6 files changed, 221 insertions(+), 4 deletions(-)
> > 
> > -- 
> > 2.35.3
> > 
> > 
> > 
> 
> --
> Mat Martineau
> Intel