Re: [PATCH mptcp-next v25 0/5] BPF redundant scheduler, part 2

[Geliang Tang <geliang.tang@suse.com>]

Hi Mat, Matt,

On Mon, Dec 19, 2022 at 05:39:59PM -0800, Mat Martineau wrote:
> On Thu, 15 Dec 2022, Geliang Tang wrote:
> 
> > v25:
> > - update calls to mptcp_subflow_set_scheduled(subflow, false) in
> >  __mptcp_subflow_push_pending().
> > - rebased on "tag: export/20221215T054923"
> > 
> 
> Thanks for all the work on this Geliang. I think it's ok to add this to the
> export branch for further testing, and any fixes/updates can be squashed if
> needed.
> 
> I do have feedback on one line to delete in patch 2 (see that reply). Not
> sure if Matthieu needs a squash-to patch for that or can update when
> applying.

I just sent a squash-to patch to delete this line in ML.

> 
> Should this be applied after the bpf_rr patches, or earlier in the "features
> other trees" section of the export branch?

The first three patches should be inserted between the commits "mptcp: add
sched_data_set_contexts helper" and "bpf: Add bpf_mptcp_sched_ops". The
last two should be applied after the commit "selftests/bpf: Add bpf_rr
test".

> 
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> 
> 
> - Mat
> 
> > Geliang Tang (5):
> >  mptcp: add scheduler wrappers
> >  mptcp: use get_send wrapper
> >  mptcp: use get_retrans wrapper

In addition, the commit logs of these two patches need to be updated
too since sock_owned_by_me() are now replaced by msk_owned_by_me().

The first one:

 Move sock_owned_by_me() check and fallback check into get_send() wrapper
 from mptcp_subflow_get_send().
->
 Move owned_by_me() and fallback checks into get_send() wrapper from
 mptcp_subflow_get_send().

The second:

 Move sock_owned_by_me() check and fallback check into get_retrans()
 wrapper from mptcp_subflow_get_retrans().
->
 Move owned_by_me() and fallback checks into get_retrans() wrapper from
 mptcp_subflow_get_retrans().

Thanks,
-Geliang

> >  selftests/bpf: Add bpf_red scheduler
> >  selftests/bpf: Add bpf_red test
> > 
> > net/mptcp/protocol.c                          | 187 +++++++++++-------
> > net/mptcp/protocol.h                          |   4 +
> > net/mptcp/sched.c                             |  69 +++++++
> > .../testing/selftests/bpf/prog_tests/mptcp.c  |  34 ++++
> > .../selftests/bpf/progs/mptcp_bpf_red.c       |  45 +++++
> > 5 files changed, 264 insertions(+), 75 deletions(-)
> > create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_red.c
> > 
> > -- 
> > 2.35.3
> > 
> > 
> > 
> 
> --
> Mat Martineau
> Intel