From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Subject: Re: [PATCH v3 mptcp-next 4/6] mptcp: track some aggregate data counters.
Date: Wed, 24 May 2023 12:05:40 +0200 [thread overview]
Message-ID: <20230524100540.GF17561@breakpoint.cc> (raw)
In-Reply-To: <df6358ce88b497eed93dff304840ddb79fba06f4.camel@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> > __aligned_u64 is preferred for uapi.
>
> Ouch! We already have a few __u64 in the same struct.
>
> Should we mix __u64 and __aligned ones? By pure luck, the both existing
> __u64 and the new one should be aligned, even without the annotation.
I'd leave the existing fields as-is, changing this now doesn't buy
us anything.
next prev parent reply other threads:[~2023-05-24 10:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 17:37 [PATCH v3 mptcp-next 0/6] mptcp: add some more diag info Paolo Abeni
2023-05-23 17:37 ` [PATCH v3 mptcp-next 1/6] mptcp: add subflow unique id Paolo Abeni
2023-05-23 17:37 ` [PATCH v3 mptcp-next 2/6] mptcp: introduce MPTCP_FULL_INFO getsockopt Paolo Abeni
2023-05-23 18:25 ` Florian Westphal
2023-05-24 6:34 ` Paolo Abeni
2023-05-24 6:36 ` Paolo Abeni
2023-05-24 7:36 ` Matthieu Baerts
2023-05-24 8:11 ` Paolo Abeni
2023-05-24 8:16 ` Matthieu Baerts
2023-05-24 9:56 ` Florian Westphal
2023-05-24 12:04 ` Matthieu Baerts
2023-05-24 12:22 ` Florian Westphal
2023-05-24 12:37 ` Matthieu Baerts
2023-05-24 8:13 ` Matthieu Baerts
2023-05-24 8:53 ` Paolo Abeni
2023-05-24 9:12 ` Matthieu Baerts
2023-05-24 10:04 ` Florian Westphal
2023-05-24 12:08 ` Matthieu Baerts
2023-05-23 17:37 ` [PATCH v3 mptcp-next 3/6] mptcp: move snd_una update earlier for fallback socket Paolo Abeni
2023-05-23 17:37 ` [PATCH v3 mptcp-next 4/6] mptcp: track some aggregate data counters Paolo Abeni
2023-05-23 18:49 ` Florian Westphal
2023-05-24 8:15 ` Paolo Abeni
2023-05-24 10:05 ` Florian Westphal [this message]
2023-05-23 17:37 ` [PATCH v3 mptcp-next 5/6] selftests: mptcp: explicitly tests aggregate counters Paolo Abeni
2023-05-23 17:37 ` [PATCH v3 mptcp-next 6/6] selftests: mptcp: add MPTCP_FULL_INFO testcase Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524100540.GF17561@breakpoint.cc \
--to=fw@strlen.de \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox