From: kernel test robot <lkp@intel.com>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: oe-kbuild-all@lists.linux.dev, Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v1 6/6] mptcp: pm: in-kernel: drop changed parameter of set_flags
Date: Fri, 28 Feb 2025 15:56:13 +0800 [thread overview]
Message-ID: <202502281544.ZIQZO9cy-lkp@intel.com> (raw)
In-Reply-To: <1e2f2a9bcdf69bd241dec4c5455c4aa135927cb6.1740638334.git.tanggeliang@kylinos.cn>
Hi Geliang,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mptcp/export]
[cannot apply to mptcp/export-net linus/master v6.14-rc4 next-20250227]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Geliang-Tang/mptcp-pm-use-pm-variable-instead-of-msk-pm/20250227-144528
base: https://github.com/multipath-tcp/mptcp_net-next.git export
patch link: https://lore.kernel.org/r/1e2f2a9bcdf69bd241dec4c5455c4aa135927cb6.1740638334.git.tanggeliang%40kylinos.cn
patch subject: [PATCH mptcp-next v1 6/6] mptcp: pm: in-kernel: drop changed parameter of set_flags
config: riscv-randconfig-002-20250228 (https://download.01.org/0day-ci/archive/20250228/202502281544.ZIQZO9cy-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250228/202502281544.ZIQZO9cy-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502281544.ZIQZO9cy-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/mptcp/pm_netlink.c: In function 'mptcp_pm_nl_set_flags':
>> net/mptcp/pm_netlink.c:1959:12: warning: variable 'changed' set but not used [-Wunused-but-set-variable]
1959 | u8 changed, mask = MPTCP_PM_ADDR_FLAG_BACKUP |
| ^~~~~~~
vim +/changed +1959 net/mptcp/pm_netlink.c
0f9f696a502e1b0 Geliang Tang 2021-01-08 1953
c7f25f7987c060b Geliang Tang 2025-02-07 1954 int mptcp_pm_nl_set_flags(struct mptcp_pm_addr_entry *local,
de258815006a162 Geliang Tang 2025-02-27 1955 struct mptcp_pm_addr_entry *remote,
c7f25f7987c060b Geliang Tang 2025-02-07 1956 struct genl_info *info)
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1957 {
c7f25f7987c060b Geliang Tang 2025-02-07 1958 struct nlattr *attr = info->attrs[MPTCP_PM_ATTR_ADDR];
6ba7ce89905c5d5 Geliang Tang 2023-06-08 @1959 u8 changed, mask = MPTCP_PM_ADDR_FLAG_BACKUP |
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1960 MPTCP_PM_ADDR_FLAG_FULLMESH;
2c8971c04f745de Geliang Tang 2025-02-07 1961 struct net *net = genl_info_net(info);
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1962 struct mptcp_pm_addr_entry *entry;
6a42477fe4491e4 Geliang Tang 2024-03-05 1963 struct pm_nl_pernet *pernet;
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1964 u8 lookup_by_id = 0;
8cdc56f99e6c33a Matthieu Baerts (NGI0 2025-02-07 1965)
6a42477fe4491e4 Geliang Tang 2024-03-05 1966 pernet = pm_nl_get_pernet(net);
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1967
c7f25f7987c060b Geliang Tang 2025-02-07 1968 if (local->addr.family == AF_UNSPEC) {
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1969 lookup_by_id = 1;
c7f25f7987c060b Geliang Tang 2025-02-07 1970 if (!local->addr.id) {
a25a8b10491bb94 Matthieu Baerts (NGI0 2025-02-07 1971) NL_SET_ERR_MSG_ATTR(info->extack, attr,
a25a8b10491bb94 Matthieu Baerts (NGI0 2025-02-07 1972) "missing address ID");
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1973 return -EOPNOTSUPP;
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1974 }
a4d68b160240815 Geliang Tang 2024-03-05 1975 }
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1976
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1977 spin_lock_bh(&pernet->lock);
c7f25f7987c060b Geliang Tang 2025-02-07 1978 entry = lookup_by_id ? __lookup_addr_by_id(pernet, local->addr.id) :
c7f25f7987c060b Geliang Tang 2025-02-07 1979 __lookup_addr(pernet, &local->addr);
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1980 if (!entry) {
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1981 spin_unlock_bh(&pernet->lock);
a25a8b10491bb94 Matthieu Baerts (NGI0 2025-02-07 1982) NL_SET_ERR_MSG_ATTR(info->extack, attr, "address not found");
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1983 return -EINVAL;
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1984 }
c7f25f7987c060b Geliang Tang 2025-02-07 1985 if ((local->flags & MPTCP_PM_ADDR_FLAG_FULLMESH) &&
1bb0d1348546ad0 Matthieu Baerts (NGI0 2025-01-23 1986) (entry->flags & (MPTCP_PM_ADDR_FLAG_SIGNAL |
1bb0d1348546ad0 Matthieu Baerts (NGI0 2025-01-23 1987) MPTCP_PM_ADDR_FLAG_IMPLICIT))) {
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1988 spin_unlock_bh(&pernet->lock);
a25a8b10491bb94 Matthieu Baerts (NGI0 2025-02-07 1989) NL_SET_ERR_MSG_ATTR(info->extack, attr, "invalid addr flags");
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1990 return -EINVAL;
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1991 }
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1992
c029cf028bb79d2 Geliang Tang 2025-02-27 1993 remote->flags = entry->flags;
c7f25f7987c060b Geliang Tang 2025-02-07 1994 changed = (local->flags ^ entry->flags) & mask;
c7f25f7987c060b Geliang Tang 2025-02-07 1995 entry->flags = (entry->flags & ~mask) | (local->flags & mask);
c7f25f7987c060b Geliang Tang 2025-02-07 1996 *local = *entry;
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1997 spin_unlock_bh(&pernet->lock);
6ba7ce89905c5d5 Geliang Tang 2023-06-08 1998
c029cf028bb79d2 Geliang Tang 2025-02-27 1999 mptcp_nl_set_flags(net, local, remote);
6ba7ce89905c5d5 Geliang Tang 2023-06-08 2000 return 0;
6ba7ce89905c5d5 Geliang Tang 2023-06-08 2001 }
6ba7ce89905c5d5 Geliang Tang 2023-06-08 2002
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-28 7:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 6:43 [PATCH mptcp-next v1 0/6] BPF path manager, part 5 Geliang Tang
2025-02-27 6:43 ` [PATCH mptcp-next v1 1/6] mptcp: pm: use pm variable instead of msk->pm Geliang Tang
2025-02-27 6:43 ` [PATCH mptcp-next v1 2/6] mptcp: pm: userspace: drop is_userspace in free_local_addr_list Geliang Tang
2025-02-27 11:44 ` Matthieu Baerts
2025-02-27 6:43 ` [PATCH mptcp-next v1 3/6] mptcp: pm: drop is_kernel in alloc_anno_list Geliang Tang
2025-02-27 6:43 ` [PATCH mptcp-next v1 4/6] mptcp: pm: in-kernel: drop is_userspace in remove_id_zero Geliang Tang
2025-02-27 12:10 ` Matthieu Baerts
2025-02-27 6:43 ` [PATCH mptcp-next v1 5/6] mptcp: pm: add remote parameter for set_flags Geliang Tang
2025-02-27 12:26 ` Matthieu Baerts
2025-02-27 6:43 ` [PATCH mptcp-next v1 6/6] mptcp: pm: in-kernel: drop changed parameter of set_flags Geliang Tang
2025-02-27 12:30 ` Matthieu Baerts
2025-02-28 7:56 ` kernel test robot [this message]
2025-02-27 7:04 ` [PATCH mptcp-next v1 0/6] BPF path manager, part 5 MPTCP CI
2025-02-27 7:48 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502281544.ZIQZO9cy-lkp@intel.com \
--to=lkp@intel.com \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox