mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: mptcp@lists.linux.dev
Cc: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Subject: [PATCH mptcp-net 1/2] Squash to "selftests: mptcp: connect: also cover alt modes"
Date: Tue, 15 Jul 2025 11:49:08 +0200	[thread overview]
Message-ID: <20250715-selftests-mptcp-connect-modes-fixes-v1-1-58fc475d9397@kernel.org> (raw)
In-Reply-To: <20250715-selftests-mptcp-connect-modes-fixes-v1-0-58fc475d9397@kernel.org>

Without that, all mptcp_connect*.sh subtests have the same name, e.g.

  mptcp_connect: ping tests  ## from mptcp_connect.sh
  mptcp_connect: ping tests  ## from mptcp_connect_checksum.sh
  mptcp_connect: ping tests  ## from mptcp_connect_mmap.sh
  mptcp_connect: ping tests  ## from mptcp_connect_sendfile.sh

In such case, the CI will only see one subtest, not 4 different ones.

To fix that, MPTCP_LIB_KSFT_TEST env var can simply be set.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh     | 3 ++-
 tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh b/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh
index 09bde1303bf79198fe9f7890cbe89901859d78e8..5dd30f9394af6a88b14936a64c50ac9566be2e6e 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh
@@ -1,4 +1,5 @@
 #!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
-"$(dirname "${0}")/mptcp_connect.sh" -m mmap "${@}"
+MPTCP_LIB_KSFT_TEST="$(basename "${0}" .sh)" \
+	"$(dirname "${0}")/mptcp_connect.sh" -m mmap "${@}"
diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh b/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh
index c50d08481581f0f8997c6f4f2174d606150bfa6a..1d16fb1cc9bb6d1f88a9fdc11206237ca2b790bb 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh
@@ -1,4 +1,5 @@
 #!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
-"$(dirname "${0}")/mptcp_connect.sh" -m sendfile "${@}"
+MPTCP_LIB_KSFT_TEST="$(basename "${0}" .sh)" \
+	"$(dirname "${0}")/mptcp_connect.sh" -m sendfile "${@}"

-- 
2.48.1


  reply	other threads:[~2025-07-15  9:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15  9:49 [PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes" Matthieu Baerts (NGI0)
2025-07-15  9:49 ` Matthieu Baerts (NGI0) [this message]
2025-07-15  9:49 ` [PATCH mptcp-net 2/2] Squash to "selftests: mptcp: connect: also cover checksum" Matthieu Baerts (NGI0)
2025-07-15  9:52 ` [PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes" Geliang Tang
2025-07-15 17:03   ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715-selftests-mptcp-connect-modes-fixes-v1-1-58fc475d9397@kernel.org \
    --to=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).