Re: [PATCH mptcp-next 1/3] mptcp: implement psock_update_sk_prot

[kernel test robot <lkp@intel.com>]

Hi Geliang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mptcp/export]
[also build test WARNING on mptcp/export-net linus/master v6.19-rc2 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Geliang-Tang/mptcp-implement-psock_update_sk_prot/20251225-170243
base:   https://github.com/multipath-tcp/mptcp_net-next.git export
patch link:    https://lore.kernel.org/r/f2508c5923c4ed365d6c12800e43a16761ed615a.1766653030.git.tanggeliang%40kylinos.cn
patch subject: [PATCH mptcp-next 1/3] mptcp: implement psock_update_sk_prot
config: arc-defconfig (https://download.01.org/0day-ci/archive/20251226/202512261144.DxrvwMS3-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251226/202512261144.DxrvwMS3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512261144.DxrvwMS3-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/mptcp/protocol.c: In function 'mptcp_bpf_rebuild_protos':
   net/mptcp/protocol.c:4043:51: error: 'sock_map_destroy' undeclared (first use in this function); did you mean 'sock_diag_destroy'?
    4043 |         prot[MPTCP_BPF_BASE].destroy            = sock_map_destroy;
         |                                                   ^~~~~~~~~~~~~~~~
         |                                                   sock_diag_destroy
   net/mptcp/protocol.c:4043:51: note: each undeclared identifier is reported only once for each function it appears in
   net/mptcp/protocol.c:4044:51: error: 'sock_map_close' undeclared (first use in this function); did you mean 'sk_msg_clone'?
    4044 |         prot[MPTCP_BPF_BASE].close              = sock_map_close;
         |                                                   ^~~~~~~~~~~~~~
         |                                                   sk_msg_clone
   net/mptcp/protocol.c: At top level:
>> net/mptcp/protocol.c:4079:12: warning: 'mptcp_bpf_update_proto' defined but not used [-Wunused-function]
    4079 | static int mptcp_bpf_update_proto(struct sock *sk, struct sk_psock *psock, bool restore)
         |            ^~~~~~~~~~~~~~~~~~~~~~


vim +/mptcp_bpf_update_proto +4079 net/mptcp/protocol.c

  4078	
> 4079	static int mptcp_bpf_update_proto(struct sock *sk, struct sk_psock *psock, bool restore)
  4080	{
  4081		int family = sk->sk_family == AF_INET6 ? MPTCP_BPF_IPV6 : MPTCP_BPF_IPV4;
  4082		int config = psock->progs.msg_parser   ? MPTCP_BPF_TX   : MPTCP_BPF_BASE;
  4083	
  4084		if (psock->progs.stream_verdict || psock->progs.skb_verdict)
  4085			config = (config == MPTCP_BPF_TX) ? MPTCP_BPF_TXRX : MPTCP_BPF_RX;
  4086	
  4087		if (restore) {
  4088			sk->sk_write_space = psock->saved_write_space;
  4089			/* Pairs with lockless read in sk_clone_lock() */
  4090			sock_replace_proto(sk, psock->sk_proto);
  4091			return 0;
  4092		}
  4093	
  4094		if (sk->sk_family == AF_INET6) {
  4095			if (mptcp_bpf_assert_proto_ops(psock->sk_proto))
  4096				return -EINVAL;
  4097	
  4098			mptcp_bpf_check_v6_needs_rebuild(psock->sk_proto);
  4099		}
  4100	
  4101		/* Pairs with lockless read in sk_clone_lock() */
  4102		sock_replace_proto(sk, &mptcp_bpf_prots[family][config]);
  4103		return 0;
  4104	}
  4105	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki