Re: [PATCH 6.12 162/265] selftests: mptcp: join: check removing signal+subflow endp

Re: [PATCH 6.12 162/265] selftests: mptcp: join: check removing signal+subflow endp

[Matthieu Baerts]

Hi Greg,

On 12/03/2026 21:09, Greg Kroah-Hartman wrote:
> 6.12-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> commit 1777f349ff41b62dfe27454b69c27b0bc99ffca5 upstream.
> 
> This validates the previous commit: endpoints with both the signal and
> subflow flags should always be marked as used even if it was not
> possible to create new subflows due to the MPTCP PM limits.

FYI, this patch adds a new subtest in the MPTCP selftests to validate
that the upstream parent commit -- 579a752464a6 ("mptcp: pm: in-kernel:
always mark signal+subflow endp as used") -- fixes a warning. Except
that this commit had a conflict and is currently not in v6.12. Sasha
sent a version without the conflict (BTW, thank you for that!):

  https://lore.kernel.org/20260309153846.1288656-1-sashal@kernel.org

I guess that's probably fine like that because the issue exposed by this
new test is not new, and it will be fixed by the missing patch soon I
suppose. Probably no need to modify this RC, and the fix can wait the
next version, but I prefer to send this message just in case people hit
the issue.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH 6.12 162/265] selftests: mptcp: join: check removing signal+subflow endp

[Greg Kroah-Hartman]

On Fri, Mar 13, 2026 at 10:54:07AM +0100, Matthieu Baerts wrote:
> Hi Greg,
> 
> On 12/03/2026 21:09, Greg Kroah-Hartman wrote:
> > 6.12-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> > 
> > commit 1777f349ff41b62dfe27454b69c27b0bc99ffca5 upstream.
> > 
> > This validates the previous commit: endpoints with both the signal and
> > subflow flags should always be marked as used even if it was not
> > possible to create new subflows due to the MPTCP PM limits.
> 
> FYI, this patch adds a new subtest in the MPTCP selftests to validate
> that the upstream parent commit -- 579a752464a6 ("mptcp: pm: in-kernel:
> always mark signal+subflow endp as used") -- fixes a warning. Except
> that this commit had a conflict and is currently not in v6.12. Sasha
> sent a version without the conflict (BTW, thank you for that!):
> 
>   https://lore.kernel.org/20260309153846.1288656-1-sashal@kernel.org
> 
> I guess that's probably fine like that because the issue exposed by this
> new test is not new, and it will be fixed by the missing patch soon I
> suppose. Probably no need to modify this RC, and the fix can wait the
> next version, but I prefer to send this message just in case people hit
> the issue.

Thanks for the info, I'll queue up that other patch for the next round
of stable releases, sorry I didn't get to it at this point in time.

greg k-h

Re: [PATCH 6.12 162/265] selftests: mptcp: join: check removing signal+subflow endp

[Matthieu Baerts]

On 13/03/2026 17:02, Greg Kroah-Hartman wrote:
> On Fri, Mar 13, 2026 at 10:54:07AM +0100, Matthieu Baerts wrote:
>> Hi Greg,
>>
>> On 12/03/2026 21:09, Greg Kroah-Hartman wrote:
>>> 6.12-stable review patch.  If anyone has any objections, please let me know.
>>>
>>> ------------------
>>>
>>> From: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>>>
>>> commit 1777f349ff41b62dfe27454b69c27b0bc99ffca5 upstream.
>>>
>>> This validates the previous commit: endpoints with both the signal and
>>> subflow flags should always be marked as used even if it was not
>>> possible to create new subflows due to the MPTCP PM limits.
>>
>> FYI, this patch adds a new subtest in the MPTCP selftests to validate
>> that the upstream parent commit -- 579a752464a6 ("mptcp: pm: in-kernel:
>> always mark signal+subflow endp as used") -- fixes a warning. Except
>> that this commit had a conflict and is currently not in v6.12. Sasha
>> sent a version without the conflict (BTW, thank you for that!):
>>
>>   https://lore.kernel.org/20260309153846.1288656-1-sashal@kernel.org
>>
>> I guess that's probably fine like that because the issue exposed by this
>> new test is not new, and it will be fixed by the missing patch soon I
>> suppose. Probably no need to modify this RC, and the fix can wait the
>> next version, but I prefer to send this message just in case people hit
>> the issue.
> 
> Thanks for the info, I'll queue up that other patch for the next round
> of stable releases

Thank you!

> sorry I didn't get to it at this point in time.

No need to apologise, I understand, no hurry :)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.