From: kernel test robot <lkp@intel.com>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: oe-kbuild-all@lists.linux.dev,
Geliang Tang <tanggeliang@kylinos.cn>,
Paolo Abeni <pabeni@redhat.com>,
Matthieu Baerts <matttbe@kernel.org>
Subject: Re: [PATCH mptcp-next] mptcp: remove unused data_ack from struct mptcp_ext
Date: Tue, 26 May 2026 17:44:11 +0200 [thread overview]
Message-ID: <202605261720.YO4kQJsj-lkp@intel.com> (raw)
In-Reply-To: <59640df9a7c0528688419655e53cb4efc50aff41.1779786007.git.tanggeliang@kylinos.cn>
Hi Geliang,
kernel test robot noticed the following build errors:
[auto build test ERROR on mptcp/export]
[also build test ERROR on mptcp/export-net linus/master v7.1-rc5 next-20260525]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Geliang-Tang/mptcp-remove-unused-data_ack-from-struct-mptcp_ext/20260526-174441
base: https://github.com/multipath-tcp/mptcp_net-next.git export
patch link: https://lore.kernel.org/r/59640df9a7c0528688419655e53cb4efc50aff41.1779786007.git.tanggeliang%40kylinos.cn
patch subject: [PATCH mptcp-next] mptcp: remove unused data_ack from struct mptcp_ext
config: s390-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20260526/202605261720.YO4kQJsj-lkp@intel.com/config)
compiler: s390x-linux-gnu-gcc (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260526/202605261720.YO4kQJsj-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605261720.YO4kQJsj-lkp@intel.com/
All errors (new ones prefixed by >>):
net/mptcp/options.c: In function 'mptcp_established_options_dss':
>> net/mptcp/options.c:607:31: error: 'struct mptcp_ext' has no member named 'data_ack'
607 | opts->ext_copy.data_ack = ack_seq;
| ^
>> net/mptcp/options.c:611:31: error: 'struct mptcp_ext' has no member named 'data_ack32'
611 | opts->ext_copy.data_ack32 = (uint32_t)ack_seq;
| ^
net/mptcp/options.c: In function 'mptcp_write_options':
net/mptcp/options.c:1479:57: error: 'struct mptcp_ext' has no member named 'data_ack'
1479 | put_unaligned_be64(mpext->data_ack, ptr);
| ^~
net/mptcp/options.c:1482:57: error: 'struct mptcp_ext' has no member named 'data_ack32'
1482 | put_unaligned_be32(mpext->data_ack32, ptr);
| ^~
vim +607 net/mptcp/options.c
6d0060f600adfd Mat Martineau 2020-01-21 561
6d0060f600adfd Mat Martineau 2020-01-21 562 static bool mptcp_established_options_dss(struct sock *sk, struct sk_buff *skb,
d87903b63e3ce1 Paolo Abeni 2021-02-19 563 bool snd_data_fin_enable,
6d0060f600adfd Mat Martineau 2020-01-21 564 unsigned int *size,
6d0060f600adfd Mat Martineau 2020-01-21 565 struct mptcp_out_options *opts)
6d0060f600adfd Mat Martineau 2020-01-21 566 {
6d0060f600adfd Mat Martineau 2020-01-21 567 struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(sk);
7279da6145bbb2 Mat Martineau 2020-07-28 568 struct mptcp_sock *msk = mptcp_sk(subflow->conn);
6d0060f600adfd Mat Martineau 2020-01-21 569 unsigned int dss_size = 0;
6d0060f600adfd Mat Martineau 2020-01-21 570 struct mptcp_ext *mpext;
6d0060f600adfd Mat Martineau 2020-01-21 571 unsigned int ack_size;
d22f4988ffecbe Christoph Paasch 2020-01-21 572 bool ret = false;
d87903b63e3ce1 Paolo Abeni 2021-02-19 573 u64 ack_seq;
6d0060f600adfd Mat Martineau 2020-01-21 574
c5b39e26d00364 Geliang Tang 2021-06-17 575 opts->csum_reqd = READ_ONCE(msk->csum_enabled);
0bac966a1f2ae0 Mat Martineau 2020-07-28 576 mpext = skb ? mptcp_get_ext(skb) : NULL;
6d0060f600adfd Mat Martineau 2020-01-21 577
7279da6145bbb2 Mat Martineau 2020-07-28 578 if (!skb || (mpext && mpext->use_map) || snd_data_fin_enable) {
c5b39e26d00364 Geliang Tang 2021-06-17 579 unsigned int map_size = TCPOLEN_MPTCP_DSS_BASE + TCPOLEN_MPTCP_DSS_MAP64;
6d0060f600adfd Mat Martineau 2020-01-21 580
c5b39e26d00364 Geliang Tang 2021-06-17 581 if (mpext) {
c5b39e26d00364 Geliang Tang 2021-06-17 582 if (opts->csum_reqd)
c5b39e26d00364 Geliang Tang 2021-06-17 583 map_size += TCPOLEN_MPTCP_DSS_CHECKSUM;
6d0060f600adfd Mat Martineau 2020-01-21 584
6d0060f600adfd Mat Martineau 2020-01-21 585 opts->ext_copy = *mpext;
c5b39e26d00364 Geliang Tang 2021-06-17 586 }
6d0060f600adfd Mat Martineau 2020-01-21 587
c5b39e26d00364 Geliang Tang 2021-06-17 588 dss_size = map_size;
7279da6145bbb2 Mat Martineau 2020-07-28 589 if (skb && snd_data_fin_enable)
9c29e36152748f Paolo Abeni 2020-07-03 590 mptcp_write_data_fin(subflow, skb, &opts->ext_copy);
1bff1e43a30e2f Paolo Abeni 2021-08-24 591 opts->suboptions = OPTION_MPTCP_DSS;
d22f4988ffecbe Christoph Paasch 2020-01-21 592 ret = true;
d22f4988ffecbe Christoph Paasch 2020-01-21 593 }
d22f4988ffecbe Christoph Paasch 2020-01-21 594
2398e3991bda7c Paolo Abeni 2020-03-04 595 /* passive sockets msk will set the 'can_ack' after accept(), even
2398e3991bda7c Paolo Abeni 2020-03-04 596 * if the first subflow may have the already the remote key handy
2398e3991bda7c Paolo Abeni 2020-03-04 597 */
d22f4988ffecbe Christoph Paasch 2020-01-21 598 opts->ext_copy.use_ack = 0;
dc093db5cc052b Paolo Abeni 2020-03-13 599 if (!READ_ONCE(msk->can_ack)) {
d22f4988ffecbe Christoph Paasch 2020-01-21 600 *size = ALIGN(dss_size, 4);
d22f4988ffecbe Christoph Paasch 2020-01-21 601 return ret;
6d0060f600adfd Mat Martineau 2020-01-21 602 }
6d0060f600adfd Mat Martineau 2020-01-21 603
e3859603ba13e7 Paolo Abeni 2021-02-11 604 ack_seq = READ_ONCE(msk->ack_seq);
37198e93ced707 Davide Caratti 2020-10-06 605 if (READ_ONCE(msk->use_64bit_ack)) {
6d0060f600adfd Mat Martineau 2020-01-21 606 ack_size = TCPOLEN_MPTCP_DSS_ACK64;
e3859603ba13e7 Paolo Abeni 2021-02-11 @607 opts->ext_copy.data_ack = ack_seq;
a0c1d0eafd1ef1 Christoph Paasch 2020-05-14 608 opts->ext_copy.ack64 = 1;
a0c1d0eafd1ef1 Christoph Paasch 2020-05-14 609 } else {
a0c1d0eafd1ef1 Christoph Paasch 2020-05-14 610 ack_size = TCPOLEN_MPTCP_DSS_ACK32;
e3859603ba13e7 Paolo Abeni 2021-02-11 @611 opts->ext_copy.data_ack32 = (uint32_t)ack_seq;
a0c1d0eafd1ef1 Christoph Paasch 2020-05-14 612 opts->ext_copy.ack64 = 0;
a0c1d0eafd1ef1 Christoph Paasch 2020-05-14 613 }
a0c1d0eafd1ef1 Christoph Paasch 2020-05-14 614 opts->ext_copy.use_ack = 1;
1bff1e43a30e2f Paolo Abeni 2021-08-24 615 opts->suboptions = OPTION_MPTCP_DSS;
6d0060f600adfd Mat Martineau 2020-01-21 616
6d0060f600adfd Mat Martineau 2020-01-21 617 /* Add kind/length/subtype/flag overhead if mapping is not populated */
6d0060f600adfd Mat Martineau 2020-01-21 618 if (dss_size == 0)
6d0060f600adfd Mat Martineau 2020-01-21 619 ack_size += TCPOLEN_MPTCP_DSS_BASE;
6d0060f600adfd Mat Martineau 2020-01-21 620
6d0060f600adfd Mat Martineau 2020-01-21 621 dss_size += ack_size;
6d0060f600adfd Mat Martineau 2020-01-21 622
6d0060f600adfd Mat Martineau 2020-01-21 623 *size = ALIGN(dss_size, 4);
6d0060f600adfd Mat Martineau 2020-01-21 624 return true;
6d0060f600adfd Mat Martineau 2020-01-21 625 }
6d0060f600adfd Mat Martineau 2020-01-21 626
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-05-26 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 9:04 [PATCH mptcp-next] mptcp: remove unused data_ack from struct mptcp_ext Geliang Tang
2026-05-26 10:41 ` MPTCP CI
2026-05-26 15:13 ` kernel test robot
2026-05-26 15:44 ` kernel test robot [this message]
2026-05-27 11:44 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202605261720.YO4kQJsj-lkp@intel.com \
--to=lkp@intel.com \
--cc=geliang@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox