Re: [PATCH net v4 2/2] selftests: mptcp: add regression test for stale ADD_ADDR on id 0 removal

[kernel test robot <lkp@intel.com>]

Hi Kalpan,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Kalpan-Jani/mptcp-pm-drop-pending-ADD_ADDR-when-removing-id-0-endpoint/20260623-033836
base:   net/main
patch link:    https://lore.kernel.org/r/20260622092838.1267134-3-kalpan.jani%40mpiricsoftware.com
patch subject: [PATCH net v4 2/2] selftests: mptcp: add regression test for stale ADD_ADDR on id 0 removal
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260623/202606231019.rN367btY-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260623/202606231019.rN367btY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606231019.rN367btY-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/mptcp/pm_kernel.c: In function 'mptcp_nl_remove_id_zero_address':
>> net/mptcp/pm_kernel.c:1154:29: error: implicit declaration of function 'mptcp_remove_anno_list_by_saddr' [-Wimplicit-function-declaration]
    1154 |                 announced = mptcp_remove_anno_list_by_saddr(msk, &anno_addr);
         |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/mptcp_remove_anno_list_by_saddr +1154 net/mptcp/pm_kernel.c

  1127	
  1128	static int mptcp_nl_remove_id_zero_address(struct net *net,
  1129						   struct mptcp_addr_info *addr)
  1130	{
  1131		struct mptcp_rm_list list = { .nr = 0 };
  1132		long s_slot = 0, s_num = 0;
  1133		struct mptcp_sock *msk;
  1134	
  1135		list.ids[list.nr++] = 0;
  1136	
  1137		while ((msk = mptcp_token_iter_next(net, &s_slot, &s_num)) != NULL) {
  1138			struct sock *sk = (struct sock *)msk;
  1139			struct mptcp_addr_info msk_local;
  1140			struct mptcp_addr_info anno_addr;
  1141			bool announced;
  1142	
  1143			if (list_empty(&msk->conn_list) || mptcp_pm_is_userspace(msk))
  1144				goto next;
  1145	
  1146			mptcp_local_address((struct sock_common *)msk, &msk_local);
  1147			if (!mptcp_addresses_equal(&msk_local, addr, addr->port))
  1148				goto next;
  1149	
  1150			lock_sock(sk);
  1151			/* Drop a possibly pending ADD_ADDR for this address. */
  1152			anno_addr = msk_local;
  1153			anno_addr.port = 0;
> 1154			announced = mptcp_remove_anno_list_by_saddr(msk, &anno_addr);
  1155			spin_lock_bh(&msk->pm.lock);
  1156			if (announced)
  1157				msk->pm.add_addr_signaled--;
  1158			mptcp_pm_remove_addr(msk, &list);
  1159			mptcp_pm_rm_subflow(msk, &list);
  1160			__mark_subflow_endp_available(msk, 0);
  1161			spin_unlock_bh(&msk->pm.lock);
  1162			release_sock(sk);
  1163	
  1164	next:
  1165			sock_put(sk);
  1166			cond_resched();
  1167		}
  1168	
  1169		return 0;
  1170	}
  1171	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki