From: Chenguang Zhao <chenguang.zhao@linux.dev>
To: mptcp@lists.linux.dev
Cc: chenguang.zhao@linux.dev, Chenguang Zhao <zhaochenguang@kylinos.cn>
Subject: [PATCH export v3 0/4] mptcp: fix TCP fallback on single-subflow MP_FAIL
Date: Wed, 12 Aug 2026 13:46:49 +0800 [thread overview]
Message-ID: <20260812054653.43799-1-chenguang.zhao@linux.dev> (raw)
From: Chenguang Zhao <zhaochenguang@kylinos.cn>
When a valid MP_FAIL is received and infinite fallback is still allowed
(single contiguous subflow), RFC8684 section 3.7 requires leaving MPTCP
mode. Today the stack only clears allow_subflows and defers the real
fallback to the later infinite-map transmit path. If no data is sent in
between, the peer can still complete the 4th ACK as MPTCP and keep using
MPTCP options.
This series adds a dedicated MPFailFallback MIB, rejects joins after
fallback via mptcp_is_fully_established(), resets when the OoO queue
blocks infinite mapping, and falls back immediately after the MP_FAIL
response through mptcp_try_fallback().
Patch 1 adds the MPFailFallback MIB.
Patch 2 rejects joins once fallback has completed.
Patch 3 resets on MP_FAIL when the OoO queue is non-empty.
Patch 4 falls back to TCP after sending the MP_FAIL response.
v3:
- Address Matthieu Baerts' review
- Introduce the MIB first (Fixes: c65c2e3bae69) and reuse
mptcp_try_fallback() in the functional fix
- Split mptcp_is_fully_established() and OoO handling into dedicated
commits for easier backport
- Check FALLBACK_DONE via test_bit()
- Drop allow_subflows from mptcp_is_fully_established() (and the
READ/WRITE_ONCE follow-up)
- On OoO failure, reset without sending MP_FAIL
- This patch series is based on the export branch, The git repository
is: git://git.kernel.org/pub/scm/linux/kernel/git/mptcp/linux.git
Chenguang Zhao (4):
mptcp: add MPFailFallback MIB
mptcp: reject joins after fallback in mptcp_is_fully_established
mptcp: reset subflow on MP_FAIL when OoO queue is non-empty
mptcp: fallback to TCP on MP_FAIL with a single subflow
net/mptcp/mib.c | 1 +
net/mptcp/mib.h | 1 +
net/mptcp/pm.c | 17 +++++++++++++++--
net/mptcp/protocol.c | 4 +++-
net/mptcp/protocol.h | 5 ++++-
5 files changed, 24 insertions(+), 4 deletions(-)
---
v2:
https://lore.kernel.org/all/20260715061830.1057851-1-chenguang.zhao@linux.dev/
v1:
https://lore.kernel.org/all/20260713064134.914507-1-chenguang.zhao@linux.dev/
--
2.25.1
next reply other threads:[~2026-08-12 5:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 5:46 Chenguang Zhao [this message]
2026-08-12 5:46 ` [PATCH export v3 1/4] mptcp: add MPFailFallback MIB Chenguang Zhao
2026-08-12 5:46 ` [PATCH export v3 2/4] mptcp: reject joins after fallback in mptcp_is_fully_established Chenguang Zhao
2026-08-12 9:45 ` Paolo Abeni
2026-08-12 15:32 ` Matthieu Baerts
2026-08-12 5:46 ` [PATCH export v3 3/4] mptcp: reset subflow on MP_FAIL when OoO queue is non-empty Chenguang Zhao
2026-08-12 6:07 ` sashiko-bot
2026-08-12 10:02 ` Paolo Abeni
2026-08-12 5:46 ` [PATCH export v3 4/4] mptcp: fallback to TCP on MP_FAIL with a single subflow Chenguang Zhao
2026-08-12 10:43 ` Paolo Abeni
2026-08-12 10:47 ` Paolo Abeni
2026-08-12 6:57 ` [PATCH export v3 0/4] mptcp: fix TCP fallback on single-subflow MP_FAIL MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812054653.43799-1-chenguang.zhao@linux.dev \
--to=chenguang.zhao@linux.dev \
--cc=mptcp@lists.linux.dev \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox