From: Greg KH <gregkh@linuxfoundation.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: sashiko-reviews@lists.linux.dev, mptcp@lists.linux.dev
Subject: Re: Patch "mptcp: annotate data-races around subflow->fully_established" has been added to the 6.12-stable tree
Date: Sun, 20 Sep 2026 15:10:41 +0200 [thread overview]
Message-ID: <2026092026-throwback-iron-bdce@gregkh> (raw)
In-Reply-To: <3b729163-10e6-44ad-bcde-24da5e8a11c1@kernel.org>
On Sun, Sep 20, 2026 at 11:33:47AM +0200, Matthieu Baerts wrote:
> Hello,
>
> On 20/09/2026 09:48, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Low] mptcp: build failure due to READ_ONCE() on bit-field
>
> Mmh, I missed the fact this commit has already been backported in commit
> 477aa7116a76 ("mptcp: annotate data-races around subflow
> ->fully_established"), but mostly reverted by caa4a79f74f3 ("mptcp:
> remove unneeded READ_ONCE() annotation").
>
> I don't know what's better here: either we leave it like that, and I can
> fix the size of the bit-field. Or we drop patch 1 and 2, and I resolve
> the small conflict on patch 3/5: commit 2b0f561f21b2 ("mptcp: avoid
> unneeded actions on subflow reset"). I can send a v2, and we can drop it
> if the other solution has been preferred.
Your v2 looks good, thanks for that, I'll go replace the patches with
those.
greg k-h
next prev parent reply other threads:[~2026-09-20 13:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 19:56 [PATCH 6.12.y 0/5] mptcp: fix recent failed backports (20260919) Matthieu Baerts (NGI0)
2026-09-19 19:56 ` [PATCH 6.12.y 1/5] mptcp: annotate data-races around subflow->fully_established Matthieu Baerts (NGI0)
2026-09-20 7:36 ` Patch "mptcp: annotate data-races around subflow->fully_established" has been added to the 6.12-stable tree gregkh
2026-09-20 7:48 ` sashiko-bot
2026-09-20 9:33 ` Matthieu Baerts
2026-09-20 13:10 ` Greg KH [this message]
2026-09-20 13:23 ` Matthieu Baerts
2026-09-19 19:56 ` [PATCH 6.12.y 2/5] mptcp: remove unneeded READ_ONCE() annotation Matthieu Baerts (NGI0)
2026-09-19 19:56 ` [PATCH 6.12.y 3/5] mptcp: avoid unneeded actions on subflow reset Matthieu Baerts (NGI0)
2026-09-20 7:36 ` Patch "mptcp: avoid unneeded actions on subflow reset" has been added to the 6.12-stable tree gregkh
2026-09-19 19:56 ` [PATCH 6.12.y 4/5] mptcp: close race between scheduler and state change Matthieu Baerts (NGI0)
2026-09-20 7:36 ` Patch "mptcp: close race between scheduler and state change" has been added to the 6.12-stable tree gregkh
2026-09-19 19:56 ` [PATCH 6.12.y 5/5] mptcp: fix bad accounting in __mptcp_subflow_push_pending() Matthieu Baerts (NGI0)
2026-09-20 7:36 ` Patch "mptcp: fix bad accounting in __mptcp_subflow_push_pending()" has been added to the 6.12-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026092026-throwback-iron-bdce@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox