Re: [PATCH mptcp-next 1/2] tls: implement tls_disconnect

[kernel test robot <lkp@intel.com>]

Hi Geliang,

kernel test robot noticed the following build errors:

[auto build test ERROR on mptcp/export]
[also build test ERROR on mptcp/export-net shuah-kselftest/next shuah-kselftest/fixes linus/master v7.3-rc7 next-20261012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Geliang-Tang/tls-implement-tls_disconnect/20261014-165935
base:   https://github.com/multipath-tcp/mptcp_net-next.git export
patch link:    https://lore.kernel.org/r/6ffac9e36dab9b4f5fdb6e55a744b35f0d51ffb4.1791967771.git.tanggeliang%40kylinos.cn
patch subject: [PATCH mptcp-next 1/2] tls: implement tls_disconnect
config: m68k-defconfig (https://download.01.org/0day-ci/archive/20261015/202610150856.tk1Ryxlc-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261015/202610150856.tk1Ryxlc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610150856.tk1Ryxlc-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/tls/tls_main.c: In function 'tls_sk_proto_free':
>> net/tls/tls_main.c:377:32: error: 'tls_device_sk_destruct' undeclared (first use in this function); did you mean 'tls_device_sendmsg'?
     377 |         if (sk->sk_destruct == tls_device_sk_destruct)
         |                                ^~~~~~~~~~~~~~~~~~~~~~
         |                                tls_device_sendmsg
   net/tls/tls_main.c:377:32: note: each undeclared identifier is reported only once for each function it appears in


vim +377 net/tls/tls_main.c

   360	
   361	static void tls_sk_proto_free(struct sock *sk,
   362				      struct tls_context *ctx,
   363				      bool free_ctx)
   364	{
   365		struct inet_connection_sock *icsk = inet_csk(sk);
   366		long timeo = sock_sndtimeo(sk, 0);
   367	
   368		if (ctx->tx_conf != TLS_BASE || ctx->rx_conf != TLS_BASE)
   369			tls_sk_proto_cleanup(sk, ctx, timeo);
   370	
   371		write_lock_bh(&sk->sk_callback_lock);
   372		WRITE_ONCE(sk->sk_prot, ctx->sk_proto);
   373		if (sk->sk_socket)
   374			WRITE_ONCE(sk->sk_socket->ops, ctx->sk_proto_ops);
   375		if (sk->sk_write_space == tls_write_space)
   376			sk->sk_write_space = ctx->sk_write_space;
 > 377		if (sk->sk_destruct == tls_device_sk_destruct)
   378			sk->sk_destruct = ctx->sk_destruct;
   379		if (free_ctx) {
   380			rcu_assign_pointer(icsk->icsk_ulp_data, NULL);
   381			if (icsk->icsk_ulp_ops) {
   382				/* Balance try_module_get in __tcp_ulp_find_autoload */
   383				module_put(icsk->icsk_ulp_ops->owner);
   384				icsk->icsk_ulp_ops = NULL;
   385			}
   386		}
   387		write_unlock_bh(&sk->sk_callback_lock);
   388		if (ctx->tx_conf == TLS_SW)
   389			tls_sw_free_ctx_tx(ctx);
   390	}
   391	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki