Re: [PATCH mptcp-next v9 4/6] mptcp: init sk->sk_prot in build_msk()

[Paolo Abeni <pabeni@redhat.com>]

On Mon, 2022-12-19 at 15:50 +0800, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
> 
> The 'sk_prot' field in token KUNIT self-tests will be dereferenced in
> mptcp_token_new_connect(). Therefore, init it with tcp_prot.
> 
> Signed-off-by: Menglong Dong <imagedong@tencent.com>
> ---
>  net/mptcp/token_test.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/mptcp/token_test.c b/net/mptcp/token_test.c
> index 5d984bec1cd8..0758865ab658 100644
> --- a/net/mptcp/token_test.c
> +++ b/net/mptcp/token_test.c
> @@ -57,6 +57,9 @@ static struct mptcp_sock *build_msk(struct kunit *test)
>  	KUNIT_EXPECT_NOT_ERR_OR_NULL(test, msk);
>  	refcount_set(&((struct sock *)msk)->sk_refcnt, 1);
>  	sock_net_set((struct sock *)msk, &init_net);
> +
> +	/* be sure the token helpers can dereference sk->sk_prot */
> +	((struct sock *)msk)->sk_prot = &tcp_prot;
>  	return msk;
>  }
>  

Since you likelly have to post another revision of this series, I think
it would be better moving this patch before "mptcp: add statistics for
mptcp socket in use" - so that self-tests are always functional.

Otherwise LGTM, thanks!

Paolo