Re: [PATCH mptcp-next v2 0/7] some cleanups

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 27/02/2024 02:40, Geliang Tang wrote:
> Hi Matt,
> 
> On Mon, Feb 26, 2024 at 11:06:11AM +0100, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 22/02/2024 09:03, Geliang Tang wrote:
>>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>>
>>> v2:
>>>  - address Matt's comments in v1
>>
>> If you don't mind, I think it would be useful to add a short changelog
>> per patch, under the commit message using '---' as separator (or using
>> 'git notes'): it would help to remember what was discussed, what was
>> applied, rejected or (accidentally or not) ignored. One line might be
>> enough, but it would be useful.
> 
> Sure, I'll use 'git notes' to add notes in the future.

Thanks!

>>> Geliang Tang (7):
>>>   mptcp: make pm_remove_addrs_and_subflows static
>>>   mptcp: drop duplicate header inclusions
>>>   mptcp: update set_flags interfaces
>>>   mptcp: set error messages for set_flags
>>>   mptcp: drop lookup_by_id in lookup_addr
>>
>> The five first patches look good to me:
>>
>> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>>
>>>   mptcp: add check_id for lookup_anno_list_by_saddr
>>>   selftests: mptcp: flush userspace addrs list
>>
>> Maybe the 6th patch can be simplified, and the 7th one can be dropped?
> 
> Please apply the 5 first patches for me. I changed the states of them as
> 'Queued' on patchwork, and 'Changes Requested' for the last two.

I will do it here, but I think it would be better to avoid applying part
of a series: the CI validated the whole series.

Here, it is OK, just some individual cleanups, it looks fine!

>> Also, please check my comments on patch 7: it is *really, really*
>> important for you to explain the *reasoning for why patches were
>> created*. Without a clear reason, we cannot accept patches.
> 
> Thanks for the note on patch 7. I'll always explain the reason for the
> patch in commit logs in the future. I promise.

Great, thanks, that will help for the reviews and for later :)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.