From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v2 0/3] Add TCP_MAXSEG socket option support
Date: Tue, 29 Apr 2025 13:11:14 +0200 [thread overview]
Message-ID: <2a0e43b4-ed28-4bb7-b0e2-8590b6d6b64e@kernel.org> (raw)
In-Reply-To: <cover.1745401025.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 23/04/2025 11:40, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v2:
> - add a new helper tcp_sock_set_maxseg.
> - add maxseg member of struct mptcp_sock.
> - add mptcp_setsockopt_all_subflows helper.
> - invoke mptcp_setsockopt_all_subflows under the msk socket lock.
> - drop mptcp_getsockopt_sol_tcp_maxseg, use mptcp_put_int_option
> instead.
Thank you for the update.
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/515
>
> Geliang Tang (3):
> tcp: add tcp_sock_set_maxseg
> mptcp: add TCP_MAXSEG sockopt support
> selftests: mptcp: sockopt: add TCP_MAXSEG sockopt tests
The two first patches look almost OK to me, please see the individual
comments. I think we can drop the 3rd one.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-04-29 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 9:40 [PATCH mptcp-next v2 0/3] Add TCP_MAXSEG socket option support Geliang Tang
2025-04-23 9:40 ` [PATCH mptcp-next v2 1/3] tcp: add tcp_sock_set_maxseg Geliang Tang
2025-04-29 11:17 ` Matthieu Baerts
2025-04-23 9:40 ` [PATCH mptcp-next v2 2/3] mptcp: add TCP_MAXSEG sockopt support Geliang Tang
2025-04-29 11:17 ` Matthieu Baerts
2025-04-23 9:40 ` [PATCH mptcp-next v2 3/3] selftests: mptcp: sockopt: add TCP_MAXSEG sockopt tests Geliang Tang
2025-04-29 11:17 ` Matthieu Baerts
2025-04-29 11:11 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a0e43b4-ed28-4bb7-b0e2-8590b6d6b64e@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox