Re: [PATCH mptcp-net 0/2] selftests: mptcp: connect: cover alt modes

[Geliang Tang <geliang@kernel.org>]

Hi Matt,

On Tue, 2025-07-08 at 19:37 +0200, Matthieu Baerts (NGI0) wrote:
> mptcp_connect.sh can be executed manually with "-m <MODE>" and "-C".
> 
> These modes should be validated, but they are not when the selftests
> are
> executed via the kselftest helpers. To fix that, new test programs
> have
> been added, simply calling mptcp_connect.sh with the right
> parameters.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

LGTM!

Reviewed-by: Geliang Tang <geliang@kernel.org>

Thanks,
-Geliang

> ---
> Matthieu Baerts (NGI0) (2):
>       selftests: mptcp: connect: also cover alt modes
>       selftests: mptcp: connect: also cover checksum
> 
>  tools/testing/selftests/net/mptcp/Makefile                  | 3 ++-
>  tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 4 ++++
>  tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh     | 4 ++++
>  tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 4 ++++
>  4 files changed, 14 insertions(+), 1 deletion(-)
> ---
> base-commit: df15676c95d593e64720b86babe913924c3d5649
> change-id: 20250708-selftests-mptcp-connect-modes-5d7aa9e1158d
> 
> Best regards,