Re: [PATCH mptcp-next v2] selftests: mptcp: fix MP_FAIL test-case

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2019 bytes --]

On Wed, 4 May 2022, Geliang Tang wrote:

> Hi Paolo,
>
> Thanks for this fix.
>
> Paolo Abeni <pabeni@redhat.com> 于2022年5月4日周三 17:07写道：
>>
>> The mentioned tests sometimes fails because the data
>> transfer completes before any packet is sent on the 2nd
>> link (the failing one).
>>
>> Address the issue reducing the "virtual" b/w available
>> on the primary link.
>>
>> Fixes: bfd4cdbe7032 ("selftests: mptcp: add MP_FAIL reset testcase")
>
> As Mat suggested in v1, this patch is better to squash to "selftests:
> mptcp: add MP_FAIL reset testcase".
>
> I just tested this patch with a 500 times loop, it works very well.
> The test log is attached.
>
> The only difference is that in my test, the test files size is reduced
> to 128K, to make the test faster.
>
> Tested-by: Geliang Tang <geliang.tang@suse.com>
>

Likewise, it's running well for me even with the smaller file size.

Paolo, are you ok with having this squashed in "selftests: mptcp: add 
MP_FAIL reset testcase"?

- Mat

>
>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>> ---
>> v1 -> v2:
>>  - slow the transfer even more (Mat)
>> ---
>>  tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
>> index b703b61562bf..c4121a721b54 100755
>> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
>> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
>> @@ -2707,7 +2707,7 @@ fail_tests()
>>
>>         # multiple subflows
>>         if reset_with_fail "MP_FAIL MP_RST" 2; then
>> -               tc -n $ns2 qdisc add dev ns2eth1 root netem rate 20mbit delay 1
>> +               tc -n $ns2 qdisc add dev ns2eth1 root netem rate 1mbit delay 5
>>                 pm_nl_set_limits $ns1 0 1
>>                 pm_nl_set_limits $ns2 0 1
>>                 pm_nl_add_endpoint $ns2 10.0.2.2 dev ns2eth2 flags subflow
>> --
>> 2.35.1
>>
>>
>

--
Mat Martineau
Intel