From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F9043ADB for ; Tue, 20 Feb 2024 17:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708450675; cv=none; b=NJpaJ3C8UvZ9brCOAAt8w8dVNe7J2211AaKT2ddX0PXBWg14kIz4bAy3TBOAbDlW9fDbse8TpdUmJTtmds5BVraytOpimTQbi5YTdCrLSMTp/MeFvNWyJjs9IB9xUKOu8x0X+BObrrYyzT1AIngDxD5UEY+HLRfpNC3WwnqMGwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708450675; c=relaxed/simple; bh=O2yOVbBJaOQ1RzjVfTBD3pRrf5V4Nge4qkax8gHjN1I=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=MPP2fVf88v1zCtmFQEz8nRTN2x7THO8Cnm4sImP8IzMkwNW9sV2qTwZRW+nAKhqGSbB/muumVmuReY1CfmnQFdMxv/+JxDIu3se3HiLWDFvlvqxgbirGQk0WZVubB9jAY04InAMReTR5T74IPB+bQu8PttxwdkaoxHgEaxKd7Ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WQnA1HH5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WQnA1HH5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09AEBC433F1; Tue, 20 Feb 2024 17:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708450674; bh=O2yOVbBJaOQ1RzjVfTBD3pRrf5V4Nge4qkax8gHjN1I=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=WQnA1HH57fiqQfD2FWBlCpioJO7sX/+Dk5crFlAb0r7kZ3msHY1UCqT/9NopZIUOc l8lBrOez53ope3+0wir4d7QgoTaeezTErQQp9WIJPws8cdruLFNbHTt2dphTtdIuEw 0hFz4Mr2+JS/Q2D2H87bNURKunr4DQQ9cRAQppm0pOuxRJR3sqhp6UfQeHZZ1gBmxB +82Ky577tyOZ/2pFUrnzFkxuCXGuXdYbqQmrPAn0ZNIOy6uhsocD40dV7N3ss9xlDN 9QG60tIVkqqBnTdgqj/aWCnVedjFrtmccQFAtblYP/AXZeJ8CstBdbxblkTKYXcWnN GPI/TIBaQnjpQ== Message-ID: <2f34c7fd-ae40-40a3-ad44-39a5ce226a85@kernel.org> Date: Tue, 20 Feb 2024 18:37:51 +0100 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mptcp-next v14 00/14] dump for userspace pm Content-Language: en-GB, fr-BE From: Matthieu Baerts To: Geliang Tang , Mat Martineau Cc: Geliang Tang , mptcp@lists.linux.dev References: <682134fb-8893-4ee0-9ddd-c0a4a4f5650b@kernel.org> Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <682134fb-8893-4ee0-9ddd-c0a4a4f5650b@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Geliang, Mat, On 20/02/2024 12:50 pm, Matthieu Baerts wrote: > Hi Geliang, > > On 20/02/2024 10:58, Geliang Tang wrote: >> From: Geliang Tang >> >> v14: >> - address Matt's comments in v13. > > Thank you for the new version! > > I didn't look at it yet, but: > >> - I have to use these lines in patch #8: >> >> local cmd_ret=0 >> local out=$(${cmd} 2>${err}) || cmd_ret=${?} >> >> The following expected code breaks pm_netlink.sh, I don't know why: >> >> local out cmd_ret=0 >> out=$(${cmd} 2>${err}) || cmd_ret=${?} >> >> If this is still a problem, I'll send a squash-to patch to fix it. > > Yes, we should either fix warnings or explicitly mark the false positive > ones as ignored. > > Can you try with the attached patch please? It is not clear to me why > the second block doesn't do the same as the first one. > > I can squash it when applying the series if there are no other comments. There are no other comments from me, thanks for the v14. Reviewed-by: Matthieu Baerts (NGI0) @Geliang: OK for you if I squash the suggested patch? @Mat: still OK for you with this v14? There are only modifications in the selftests (patches 8, 9 and 14) except a small change in patch 5. Cheers, Matt -- Sponsored by the NGI0 Core fund.