Re: [PATCH mptcp-next v2] mptcp: fix checksum byte order

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Sat, 14 May 2022, Matthieu Baerts wrote:

> Hi Paolo, Mat,
>
> On 10/05/2022 18:25, Paolo Abeni wrote:
>> The MPTCP code typecasts the checksum value to u16 and
>> then convert it to big endian while storing the value into
>> the MPTCP option.
>>
>> As a result, the wire encoding for little endian host is
>> wrong, and that causes interoperabilty interoperability
>> issues with other implementation or host with different endianess.
>>
>> Address the issue writing in the packet the unmodified __sum16 value.
>>
>> MPTCP checksum is disabled by default, interoperating with systems
>> with bad mptcp-level csum encodying should cause fallback to TCP.
>
> Thank you for the patch and the review!
>
> Now in our tree (fixes for -net) with Mat's RvB tag:
>
> - 5291df4774c1: mptcp: fix checksum byte order (with conflicts)
> - Results: 128393ceec9b..35e8b300fc90 (export-net)
>

Matthieu, Paolo -

I'm planning to send this patch and "mptcp: Do TCP fallback on early DSS 
checksum failure" to the -net branch on Tuesday - any concerns with that?

Thanks,

--
Mat Martineau
Intel