Re: [PATCH mptcp-next v3 2/8] mptcp: MIB counters for sent MP_JOIN

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 08/08/2024 04:46, Geliang Tang wrote:
> On Tue, 2024-08-06 at 13:18 +0200, Matthieu Baerts (NGI0) wrote:
>> Recently, a few issues have been discovered around the creation of
>> additional subflows. Without these counters, it was difficult to
>> point
>> out the reason why some subflows were not created as expected.
>>
>> These counters should have been added earlier, because there is no
>> other
>> simple ways to extract such information from the kernel, and
>> understand
>> why subflows have not been created.
>>
>> While at it, some pr_debug() have been added, just in case the errno
>> needs to be printed.

(...)

>> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
>> index a7fb4d46e024..fdeb7df8b095 100644
>> --- a/net/mptcp/subflow.c
>> +++ b/net/mptcp/subflow.c
>> @@ -1575,12 +1575,17 @@ int __mptcp_subflow_connect(struct sock *sk,
>> const struct mptcp_pm_local *local,
>>  	u32 remote_token;
>>  	int addrlen;
>>  
>> +	/* The userspace PM sent the request too early? */
>>  	if (!mptcp_is_fully_established(sk))
>>  		goto err_out;
>>  
>>  	err = mptcp_subflow_create_socket(sk, local->addr.family,
>> &sf);
>> -	if (err)
>> +	if (err) {
>> +		MPTCP_INC_STATS(sock_net(sk),
>> MPTCP_MIB_JOINSYNTXCREATSKERR);
>> +		pr_debug("msk=%p local=%d remote:%d create sock
>> error: %d\n",
> 
> It's better to use "remote=%d" instead of "remote:%d" I guess. Same
> below.

Indeed, I see we usually use '=', I can do the modification when
applying the patches if there is nothing bigger to fix.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.