[MPTCP] Re: [PATCH] squashto: mptcp: schedule worker when subflow is closed

[Mat Martineau <mathew.j.martineau at linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On Wed, 10 Feb 2021, Matthieu Baerts wrote:

> Hi Paolo,
>
> On 10/02/2021 17:04, Paolo Abeni wrote:
>> On Wed, 2021-02-10 at 13:47 +0100, Florian Westphal wrote:
>>> When remote side closes a subflow we should schedule the worker to
>>> dispose of the subflow in a timely manner.
>>> 
>>> Otherwise, SF_CLOSED event won't be generated until the mptcp
>>> socket itself is closing or local side is closing another subflow.
>>> 
>>> As noted by Paolo and Matthieu, a subflow that moves to TCP_CLOSE state
>>> might still have data in its rx queue.
>
> (...)
>
>> 
>> LGTM!
>> 
>> @Matttbe: could you please double check this one vs issues/154?
>
> Sure! I should have commented here instead of on GH :)
> I ran this for more than 3h now and I was not able to reproduce this issue! I 
> just stopped the loop.
>
> It looks good to me but I prefer to wait for Mat's ACK as he was the reviewer 
> of the original patch. I can always remove his RvB tag and re-add it later if 
> needed.
>
> Thanks for your work!
>

Ack from me as well - please squash and keep the RvB!


--
Mat Martineau
Intel