Re: [PATCH mptcp-next v5 01/12] selftests: mptcp: capitalize ok/fail/skip

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 26/02/2024 10:43, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Most scripts print uppercase [ OK ], [FAIL] and [SKIP] as test results,
> but lowercase ones are used in diag.sh, mptcp_join.sh and simult_flows.sh.
> To maintain consistency with other scripts, this patch capitalizes these
> lowercase [ ok ], [ fail ] and [ skip ]:
> 
>     [ ok ]   -> [ OK ]   	in diag.sh, mptcp_join.sh
>     [ fail ] -> [FAIL]		in diag.sh, mptcp_join.sh, simult_flows.sh
>     [ skip ] -> [SKIP]		in diag.sh, mptcp_join.sh

I think this could be squashed with patch 4/12: OK the behaviour is
changed, but that's still the same info being printed. This can be
justified with a simple "we uniform how the results are presented with
colours".

If you change that, I think it would be better to add new helpers to
print OK/FAIL/SKIP string from one place, like it is done in
mptcp_join.sh. So if needed, we can easily change how the results are
presented later instead of having to change it in different places.

We could even have these helpers in the lib:


 mptcp_lib_print_success()
 {
	mptcp_lib_print_ok "[ OK ]${1:+ ${*}}"
 }

 mptcp_lib_print_fail()
 {
	mptcp_lib_print_err "[FAIL]${1:+ ${*}}"
 }

 mptcp_lib_print_skip()
 {
	mptcp_lib_print_warn "[SKIP]${1:+ ${*}}"
 }

WDYT?

(...)
Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.