From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next] selftests/bpf: Drop cgroup_fd of run_mptcpify
Date: Wed, 15 Jan 2025 10:31:43 +0100 [thread overview]
Message-ID: <43488d28-e219-4646-af25-61c40b229074@kernel.org> (raw)
In-Reply-To: <38e34a835050f35b7f14f7938b20f86a97ac0836.1736926065.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 15/01/2025 08:28, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> The parameter 'cgroup_fd' of run_mptcpify() is useless, drop it.
(detail: s/useless/unused/)
The modification looks good to me, thank you!
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Do you want to send it directly to the BPF maintainers, for the
bpf-next/net tree? We don't have other changes that are ready to send.
Or I park it in our tree, and we send it later (no urgency I guess)?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-01-15 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 7:28 [PATCH mptcp-next] selftests/bpf: Drop cgroup_fd of run_mptcpify Geliang Tang
2025-01-15 8:39 ` MPTCP CI
2025-01-15 9:31 ` Matthieu Baerts [this message]
2025-01-15 9:34 ` Geliang Tang
2025-01-17 9:57 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43488d28-e219-4646-af25-61c40b229074@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox