Re: [PATCH mptcp-next] Squash to "selftests: mptcp: get stats just before timing out"

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 14/11/2025 02:30, Geliang Tang wrote:
> Hi Matt,
> 
> Thanks for this fix.
> 
> On Thu, 2025-11-13 at 12:11 +0100, Matthieu Baerts (NGI0) wrote:
>> Geliang reported that mptcp_connect.sh test runtime got increased
>> after
>> this patch.
>>
>> That's because the previous 'kill' command was only killing the
>> background job, but the 'sleep' command was still running.
>>
>> It is not very clear to me why there was a delay at the end, but
>> switching to mptcp_lib_kill_group_wait to kill the background job and
>> the running command fixed the issue. The new code is also looking
>> clearer I think, so that's good.
>>
>> Link:
>> https://lore.kernel.org/2a6869ca39bda7ddf8b486cd03e0867b30e0d565.camel@kernel.org
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> It works.
> 
>     Reviewed-by: Geliang Tang <geliang@kernel.org>

Thank you for the review, just applied:

New patches for t/upstream:
- 39266eb8cdba: Squash to "selftests: mptcp: get stats just before
timing out"
- Results: 24d7b3380fc2..e804ecd59ca4 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/3210c91543d4fb12e46c89fefb9d9ff78be4a471/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.