From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-net 2/5] selftests: mptcp: simult flows: define missing vars
Date: Wed, 14 Feb 2024 19:14:42 +0100 [thread overview]
Message-ID: <4894617c-8f44-4011-a913-e1cf11b36ea1@kernel.org> (raw)
In-Reply-To: <daf8c52d209822d296ee64c2485ee4d4bf14d176.1707797566.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 13/02/2024 05:14, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> The variables 'large', 'small', 'sout', 'cout', 'capout' and 'size' are
> used in multiple functions, so they should be defined as global variables.
> This patch redefines them at the beginning of simult_flows.sh.
>
> Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests")
Even if I agree it is better to clearly define global variables at the
beginning, it is not a mistake to define them in a function.
My main point is that it is maybe easier not to consider this as a fix:
it looks like backporting this to stable will create conflicts. They
will be easy to resolve, but still, it will take a bit of time to a few
people. If it doesn't fix an issue, isn't a preparation patch or doesn't
ease the backport of other patches, maybe better to target -next
(without the "Fixes" tag). WDYT?
If there are no other modifications in the series and no objections, no
need to send a new version, I can apply the patch 2 in -next. If you
need to send a v2, please move this patch after all the other fixes of
the series (or as part of a new series).
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-02-14 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 4:14 [PATCH mptcp-net 0/5] add helpers and vars in mptcp_lib.sh, part 1 Geliang Tang
2024-02-13 4:14 ` [PATCH mptcp-net 1/5] selftests: mptcp: netlink: drop duplicate var ret Geliang Tang
2024-02-13 4:14 ` [PATCH mptcp-net 2/5] selftests: mptcp: simult flows: define missing vars Geliang Tang
2024-02-14 18:14 ` Matthieu Baerts [this message]
2024-02-13 4:14 ` [PATCH mptcp-net 3/5] selftests: mptcp: add ss mptcp support checks Geliang Tang
2024-02-14 18:15 ` Matthieu Baerts
2024-02-13 4:14 ` [PATCH mptcp-net 4/5] selftests: mptcp: join: change capture/checksum as bool Geliang Tang
2024-02-14 18:16 ` Matthieu Baerts
2024-02-13 4:14 ` [PATCH mptcp-net 5/5] selftests: mptcp: diag: change timeout_poll to 30 Geliang Tang
2024-02-13 5:04 ` selftests: mptcp: diag: change timeout_poll to 30: Tests Results MPTCP CI
2024-02-13 5:25 ` MPTCP CI
2024-02-14 18:16 ` [PATCH mptcp-net 5/5] selftests: mptcp: diag: change timeout_poll to 30 Matthieu Baerts
2024-02-14 18:14 ` [PATCH mptcp-net 0/5] add helpers and vars in mptcp_lib.sh, part 1 Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4894617c-8f44-4011-a913-e1cf11b36ea1@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox