From: Matthieu Baerts <matttbe@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>,
Jason Xing <kernelxing@tencent.com>,
MPTCP Upstream <mptcp@lists.linux.dev>
Subject: Re: [PATCH net-next] mptcp: fix possible NULL dereferences
Date: Mon, 6 May 2024 17:04:34 +0200 [thread overview]
Message-ID: <48d71ee4-7b01-48a8-a2ec-9030204eac07@kernel.org> (raw)
In-Reply-To: <20240506123032.3351895-1-edumazet@google.com>
Hi Eric,
(+cc MPTCP ML for the CI, patch tracking, and other devs)
On 06/05/2024 14:30, Eric Dumazet wrote:
> subflow_add_reset_reason(skb, ...) can fail.
>
> We can not assume mptcp_get_ext(skb) always return a non NULL pointer.
Good catch! Thank you for the fix!
It looks good to me:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
parent reply other threads:[~2024-05-06 15:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240506123032.3351895-1-edumazet@google.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48d71ee4-7b01-48a8-a2ec-9030204eac07@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox