Re: [PATCH mptcp-next v6 7/8] selftests: bpf: add bpf_first scheduler

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Sat, 26 Mar 2022, Geliang Tang wrote:

> This patch implemented the simplest MPTCP scheduler, named bpf_first,
> which always picks the first subflow to send data.
>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
> tools/testing/selftests/bpf/bpf_tcp_helpers.h | 12 ++++++++
> tools/testing/selftests/bpf/progs/bpf_first.c | 30 +++++++++++++++++++
> 2 files changed, 42 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/progs/bpf_first.c
>
> diff --git a/tools/testing/selftests/bpf/bpf_tcp_helpers.h b/tools/testing/selftests/bpf/bpf_tcp_helpers.h
> index f92357597e63..5bb21b24231f 100644
> --- a/tools/testing/selftests/bpf/bpf_tcp_helpers.h
> +++ b/tools/testing/selftests/bpf/bpf_tcp_helpers.h
> @@ -197,6 +197,18 @@ struct tcp_congestion_ops {
> 	void *owner;
> };
>
> +#define MPTCP_SCHED_NAME_MAX 16
> +
> +struct mptcp_sched_ops {
> +	char name[MPTCP_SCHED_NAME_MAX];
> +
> +	void (*init)(struct mptcp_sock *msk);
> +	void (*release)(struct mptcp_sock *msk);
> +
> +	struct sock *	(*get_subflow)(struct mptcp_sock *msk);
> +	void *owner;
> +};
> +
> #define min(a, b) ((a) < (b) ? (a) : (b))
> #define max(a, b) ((a) > (b) ? (a) : (b))
> #define min_not_zero(x, y) ({			\
> diff --git a/tools/testing/selftests/bpf/progs/bpf_first.c b/tools/testing/selftests/bpf/progs/bpf_first.c
> new file mode 100644
> index 000000000000..3ae5c1eab5f5
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/bpf_first.c

I suggest naming this mptcp_bpf_first.c instead, to clarify that it's 
specific to MPTCP.

- Mat

> @@ -0,0 +1,30 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/* Copyright (c) 2022, SUSE. */
> +
> +#include <linux/bpf.h>
> +#include "bpf_tcp_helpers.h"
> +
> +char _license[] SEC("license") = "GPL";
> +
> +SEC("struct_ops/mptcp_sched_first_init")
> +void BPF_PROG(mptcp_sched_first_init, struct mptcp_sock *msk)
> +{
> +}
> +
> +SEC("struct_ops/mptcp_sched_first_release")
> +void BPF_PROG(mptcp_sched_first_release, struct mptcp_sock *msk)
> +{
> +}
> +
> +struct sock *BPF_STRUCT_OPS(bpf_first_get_subflow, struct mptcp_sock *msk)
> +{
> +	return msk->first;
> +}
> +
> +SEC(".struct_ops")
> +struct mptcp_sched_ops first = {
> +	.init		= (void *)mptcp_sched_first_init,
> +	.release	= (void *)mptcp_sched_first_release,
> +	.get_subflow	= (void *)bpf_first_get_subflow,
> +	.name		= "bpf_first",
> +};
> -- 
> 2.34.1
>
>
>

--
Mat Martineau
Intel