Re: [MPTCP] [MPTCP][PATCH v2 mptcp-next 1/5] mptcp: export mptcp_subflow_active

[Paolo Abeni <pabeni@redhat.com>]

On Wed, 2021-03-24 at 16:51 +0800, Geliang Tang wrote:
> This patch exported the static function mptcp_subflow_active.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
>  net/mptcp/protocol.c | 2 +-
>  net/mptcp/protocol.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index 9d7e7e13fba8..3ad236689480 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
> @@ -399,7 +399,7 @@ static void mptcp_set_timeout(const struct sock *sk, const struct sock *ssk)
>  	mptcp_sk(sk)->timer_ival = tout > 0 ? tout : TCP_RTO_MIN;
>  }
>  
> -static bool mptcp_subflow_active(struct mptcp_subflow_context *subflow)
> +bool mptcp_subflow_active(struct mptcp_subflow_context *subflow)
>  {
>  	struct sock *ssk = mptcp_subflow_tcp_sock(subflow);

possibly is better to simply move the function definition to the
protocol.h header, as 'static inline' one.

Thanks!

Paolo