From: Matthieu Baerts <matttbe@kernel.org>
To: Gang Yan <gang_yan@foxmail.com>,
Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>
Cc: Gang Yan <yangang@kylinos.cn>, mptcp@lists.linux.dev
Subject: Re: [PATCH 2/3] selftests: mptcp: relax conditions in SYN_TX validation
Date: Thu, 9 Jan 2025 18:39:03 +0100 [thread overview]
Message-ID: <568740da-e742-4b44-bc31-7a1b879d97b4@kernel.org> (raw)
In-Reply-To: <tencent_501B9947760682D23ADE286C65020C801307@qq.com>
Hi Gang,
On 09/01/2025 14:32, Gang Yan wrote:
> From: Gang Yan <yangang@kylinos.cn>
>
> In ADD_ADDR timeout test cases, the syn_tx MIB counter is not an
> accurate number.
Please explain why this counter is not an accurate number.
When you say that, it sounds like there is something to fix in the
kernel, but not in the tests.
(It might help to squash this patch with the next one, or to rephrase it
to say that a future test will do some retransmissions)
> This patch introduces '+n' to 'join_syn_tx'
> to relax the strict condition.
(...)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-01-09 17:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 13:32 [PATCH 2/3] selftests: mptcp: relax conditions in SYN_TX validation Gang Yan
2025-01-09 17:39 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568740da-e742-4b44-bc31-7a1b879d97b4@kernel.org \
--to=matttbe@kernel.org \
--cc=gang_yan@foxmail.com \
--cc=geliang@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox