On Mon, 8 Feb 2021, Geliang Tang wrote: > v5: > - use struct mptcp_rm_list instead of the ids array. > - simplify mptcp_pm_remove_addrs_and_subflows. > - apply: tag export/20210207T062839 + patchset "move to next addr and > testcases". > Thanks Geliang! I only had a couple of minor comments doing visual code review, they affect individual patches but not the final code. That's all I saw in visual code review, I will look at the test output and pcaps tomorrow. Have you tested what happens if there's an incoming rm_addr with id 0, since we never send an ADD_ADDR for the initial subflow? -- Mat Martineau Intel