Re: [PATCH mptcp-next 1/2] selftests: mptcp: run fail_test in main shell during join test

[Matthieu Baerts <matttbe@kernel.org>]

Hi Gang,

On 24/07/2026 08:52, Gang Yan wrote:
> From: Gang Yan <yangang@kylinos.cn>
> 
> check_transfer() compares the input and output files byte-by-byte using
> `cmp -l "$in" "$out" | while read ...`. Because the while-loop body runs
> in a subshell (the script sets neither lastpipe nor pipefail), the
> fail_test call inside it -- which sets the global ret/last_test_failed --
> and the `return 1` both act on the subshell, not on check_transfer().
> check_transfer() thus always falls through to `return 0`, and any data
> corruption affecting only the payload (leaving the subflow/PM counters
> untouched) is silently reported as PASS.

Thanks, now in our tree (I changed the commit title, I hope that's OK)

New patches for t/upstream-net and t/upstream:
- 3e32d738332f: selftests: mptcp: join: mark tests with data corruption
as failed
- Results: c00da97f2a8c..14dbb670bb6e (export-net)
- Results: 95ac470148fe..ddf9f880a057 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/2c0ef2a0cdbea15d71a70a858397322358520133/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/fdfb144e9842f54cc7d121e468375e2b91aa8575/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.