From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v4 0/4] add netns helpers
Date: Wed, 30 Oct 2024 18:34:23 +0100 [thread overview]
Message-ID: <5952d268-5c4d-4623-b91c-44e6db4395a6@kernel.org> (raw)
In-Reply-To: <cover.1730260715.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 30/10/2024 05:03, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v4:
> - Use netns_new/netns_free instead of create_netns/cleanup_netns as
> Martin suggested.
>
> The commit 1e115a58be0ff ("selftests/bpf: netns_new() and netns_free()
> helpers.") now in bpf-next makes v2 of this set useless. v3 only uses
> these new helpers in mptcp selftests and drops other patches.
Thank you for the modifications! The new version looks good to me:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
If that's OK, I will wait for a review from the BPF maintainers before
applying these patches in our repo, not to do too many manipulations
just in case an (unexpected) new version is required.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-10-30 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 4:03 [PATCH mptcp-next v4 0/4] add netns helpers Geliang Tang
2024-10-30 4:03 ` [PATCH mptcp-next v4 1/4] selftests/bpf: Drop netns helpers in mptcp Geliang Tang
2024-10-30 4:03 ` [PATCH mptcp-next v4 2/4] Squash to "selftests/bpf: Add mptcp_subflow bpf_iter subtest" Geliang Tang
2024-10-30 4:03 ` [PATCH mptcp-next v4 3/4] Squash to "selftests/bpf: Add bpf scheduler test" Geliang Tang
2024-10-30 4:03 ` [PATCH mptcp-next v4 4/4] Squash to "selftests/bpf: Add bpf_first scheduler & test" Geliang Tang
2024-10-30 5:14 ` [PATCH mptcp-next v4 0/4] add netns helpers MPTCP CI
2024-10-30 17:34 ` Matthieu Baerts [this message]
2024-11-06 3:52 ` Geliang Tang
2024-11-06 13:59 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5952d268-5c4d-4623-b91c-44e6db4395a6@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox