Re: [PATCH mptcp-net] mptcp: pm: do not remove closing subflows

[Matthieu Baerts <matttbe@kernel.org>]

Hello,

On 30/08/2024 17:36, Matthieu Baerts (NGI0) wrote:
> In a previous fix, the in-kernel path-manager has been modified not to
> retrigger the removal of a subflow if it was already closed, e.g. when
> the initial subflow is removed, but kept in the subflows list.
> 
> To be complete, this fix should also skip the subflows that are in any
> closing state: mptcp_close_ssk() will initiate the closure, but the
> switch to the TCP_CLOSE state depends on the other peer.

As discussed at the last meeting, the patch looks OK. I then just
applied it with Paolo's Acked-by:

New patches for t/upstream-net and t/upstream:
- 0986f9be4a5c: mptcp: pm: do not remove closing subflows
- Results: 98b1e473ae39..400d24177d84 (export-net)
- Results: 48a08655247c..2ce52e0f26d3 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/7ff625c9345c4313b66dba10977bbfa1f5350a3f/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/f024f47bc584b29fa1f211c82317c41ef7ac2d01/checks

> Suggested-by: Paolo Abeni <pabeni@redhat.com>
> Fixes: Fixes: 58e1b66b4e4b ("mptcp: pm: do not remove already closed subflows")

... and I removed the duplicated 'Fixes' word.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.