From: Paolo Abeni <pabeni@redhat.com>
To: Geliang Tang <geliang.tang@suse.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next 1/4] mptcp: update __mptcp_push_pending
Date: Wed, 28 Sep 2022 13:02:07 +0200 [thread overview]
Message-ID: <5b186defb2217a8de5ef73c4a8f0809dac920d07.camel@redhat.com> (raw)
In-Reply-To: <0b90e9ec304d919c833863e056f8e6c7b62d0dc2.1664358100.git.geliang.tang@suse.com>
On Wed, 2022-09-28 at 17:48 +0800, Geliang Tang wrote:
> To support redundant package schedulers more easily, this patch moves the
> packet scheduler out of the dfrags loop in __mptcp_push_pending(), invoke
> mptcp_sched_get_send() only once.
I fear the above will make cause hitting HoL blocking [more]
frequently/easily. I'm not sure if the simult_flows.sh self test will
catch that, but you should see a measurably worse running time for such
test - in non debug build, as the average of multiple runs.
I'm sorry, I can't see a feasible way out here :(
/P
next prev parent reply other threads:[~2022-09-28 11:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:48 [PATCH mptcp-next 0/4] refactor push pending Geliang Tang
2022-09-28 9:48 ` [PATCH mptcp-next 1/4] mptcp: update __mptcp_push_pending Geliang Tang
2022-09-28 11:02 ` Paolo Abeni [this message]
2022-09-28 12:52 ` Geliang Tang
2022-09-29 0:02 ` Mat Martineau
2022-09-28 9:48 ` [PATCH mptcp-next 2/4] mptcp: add do_push_pending helper Geliang Tang
2022-09-28 9:48 ` [PATCH mptcp-next 3/4] mptcp: update __mptcp_subflow_push_pending Geliang Tang
2022-09-28 9:48 ` [PATCH mptcp-next 4/4] mptcp: simplify __mptcp_subflow_push_pending Geliang Tang
2022-09-28 11:56 ` mptcp: simplify __mptcp_subflow_push_pending: Tests Results MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b186defb2217a8de5ef73c4a8f0809dac920d07.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox