Re: [PATCH mptcp-net] mptcp: fix subflow traveral at disconnect time

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Wed, 6 Jul 2022, Matthieu Baerts wrote:

> Hi Paolo,
>
> On 06/07/2022 13:18, Paolo Abeni wrote:
>> At disconnect time the MPTCP protocol traverse the subflows
>> list closing each of them. In some circumstances - MPJ subflow,
>> passive MPTCP socket, the latter operation can remove the
>> subflow from the list, invalidating the current iterator.
>>
>> Address the issue using the safe list traversing helper
>> variant.
>>
>> Reported-by: van fantasy <g1042620637@gmail.com>
>> Fixes: b29fcfb54cd7 ("mptcp: full disconnect implementation")
>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>> ---
>> I think this should go soon upstream, sending here to trigger the CI
>>
>> A pktdrill test will follow.
>
> Because the CI report was not fully green, I ran the full tests suite on
> my side (with and without a debug kernel) and I didn't spot any issues.
>
> Tested-by: Matthieu Baerts <matthieu.baerts@tessares.net>
>
> The patch looks good to me. If we can wait a bit, I guess it is better
> to wait for Mat to review it. But I don't mind applying now if needed.
>

Fine with me to apply it:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

>
> Also, I think we should probably add a new macro on net-next:
>
>  mptcp_for_each_subflow_safe(msk, subflow, tmp)
>
> WDYT?

+1

--
Mat Martineau
Intel