From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 322DE1D90BD for ; Mon, 6 Jan 2025 09:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736155031; cv=none; b=e7shoZAw6/AVwQiTOdWBsWD0GJ7Sv3nF3q+M+uwVz9v+SBJeQSTDmoYC6OdNuMASNrcHSkYoAw+mlU3kI92rf7r37xl6LNf8Jbo6B9YbMFNmNsoW56xyFnpwlrwFuq/bJDAylRQcHHudx8RQV/cQRKjx2MdeDhAAnLG0lDenLVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736155031; c=relaxed/simple; bh=7ucUAMtsOMJS2uClZUPruSKLMsqrFXE8M0Oijspp7H8=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=mNg3V6LFjc9dfgXIeNKYn2ZELBBzBrhV5PT4lvdtTM0VAIYRi5vNtdqOicnG6JvVjG3yXAZ8UkBmQFUE2jeCtDq3Sh+gfWz0BtScOF26C+81yWp5HELsxMHIXNTAZl33bLIFCasWedWym0slyyV40Ju6kulArI/KMx+8fKRGCsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KEYXsUMW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KEYXsUMW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3863CC4CED2; Mon, 6 Jan 2025 09:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736155030; bh=7ucUAMtsOMJS2uClZUPruSKLMsqrFXE8M0Oijspp7H8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=KEYXsUMWRx0djU8EOvF6sE40yemv+rAiBhm8U7ksw3e6Ib0adzsNB0uy3kptb0ypw LYNEIJZXPYVLAiMv+/zX0pQHjmmCaTAuHlmXHCVtakv3+IvGn5azlA9CbYBcdxn8Fd LU1WAYbsgR5aoUEiB8Wt0G0NwKxguF6VJXoV0yfFM8ozLV4NoiqOLQ5DJ41Eq67DaN /BKmaIvq2q3DUNUQAh7FuQnosxbY8du0+cGKeYNooP19jhEkrjrsxzJBNJ9LsKR03y vY2kri7oVL2Sb/cxTdJFdWCF6Sm/yT5tGnnM/nYXULs94RlvGmpdx5ICH3Pjvzzar+ FaOjIWub5z6rg== Message-ID: <664bedcc-a172-46b6-8c0e-a023477ce98a@kernel.org> Date: Mon, 6 Jan 2025 10:17:08 +0100 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next v7 01/11] mptcp: pm: more precise error messages Content-Language: en-GB To: Geliang Tang , mptcp@lists.linux.dev References: <702733ca36c469e621a3d4e9173eeda587dba85c.1736150983.git.tanggeliang@kylinos.cn> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <702733ca36c469e621a3d4e9173eeda587dba85c.1736150983.git.tanggeliang@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Geliang, On 06/01/2025 09:16, Geliang Tang wrote: > From: "Matthieu Baerts (NGI0)" > > Some errors reported by the userspace PM were vague: "this or that is > invalid". > > It is easier for the userspace to know which part is wrong, instead of > having to guess that. > > By splitting some error messages, NL_SET_ERR_MSG_ATTR() can be used > instead of GENL_SET_ERR_MSG() in order to give an additional hint to the > userspace developers about which attribute is wrong. > > Signed-off-by: Matthieu Baerts (NGI0) If you modify the behaviour of a patch, you can add your 'co-dev' + 'sob' tags. Also, please add an individual changelog, easier for the reviewers to spot what has changed. > --- > net/mptcp/pm_userspace.c | 39 +++++++++++++++++++++++++++++---------- > 1 file changed, 29 insertions(+), 10 deletions(-) > > diff --git a/net/mptcp/pm_userspace.c b/net/mptcp/pm_userspace.c > index a3d477059b11..40fd2f788196 100644 > --- a/net/mptcp/pm_userspace.c > +++ b/net/mptcp/pm_userspace.c (...) > @@ -579,17 +591,24 @@ int mptcp_userspace_pm_set_flags(struct sk_buff *skb, struct genl_info *info) > if (ret < 0) > goto set_flags_err; > > + if (loc.addr.family == AF_UNSPEC) { > + NL_SET_ERR_MSG_ATTR(info->extack, attr, > + "invalid local address family"); > + ret = -EINVAL; > + goto set_flags_err; > + } > + > if (attr_rem) { > ret = mptcp_pm_parse_entry(attr_rem, info, false, &rem); > if (ret < 0) > goto set_flags_err; > - } > > - if (loc.addr.family == AF_UNSPEC || > - rem.addr.family == AF_UNSPEC) { > - GENL_SET_ERR_MSG(info, "invalid address families"); > - ret = -EINVAL; > - goto set_flags_err; > + if (rem.addr.family == AF_UNSPEC) { As I mentioned in a previous version, this is changing the behaviour: this remote attribute is no longer mandatory. I'm still unsure about making it optional, because mptcp_pm_nl_mp_prio_send_ack() will pick only one subflow, not all the ones with the specified local address. It looks better to keep it mandatory. At least here, you should not move it under "if (attr_rem)". (and maybe it makes more sense to have this patch after 07/11 ("mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible"), but that's a detail, fine here) > + NL_SET_ERR_MSG_ATTR(info->extack, attr_rem, > + "invalid remote address family"); > + ret = -EINVAL; > + goto set_flags_err; > + } > } > > if (loc.flags & MPTCP_PM_ADDR_FLAG_BACKUP) Cheers, Matt -- Sponsored by the NGI0 Core fund.