Re: [PATCH, mptcp-next] selftests: mptcp: Add a check for 'add_addr_accepted'

[Geliang Tang <geliang@kernel.org>]

Hi Gang,

Thanks for this follow-up patch.

On Thu, 2025-11-06 at 15:54 +0800, Gang Yan wrote:
> From: Gang Yan <yangang@kylinos.cn>
> 
> The previous 'delete re-add signal' test did not validate the
> 'add_addr_signal' and 'add_addr_accepted' counters. These counters
> are crucial for ensuring the MPTCP path manager correctly handles the
> subflow creation via 'ADD_ADDR'.
> 
> Signed-off-by: Gang Yan <yangang@kylinos.cn>

Looks good!

Reviewed-by: Geliang Tang <geliang@kernel.org>

Except that we typically do not use capital letters to start the
subject line. Let's have Matt update the subject when applying this
patch.

Thanks,
-Geliang

> ---
>  tools/testing/selftests/net/mptcp/mptcp_join.sh | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index 4faf58fecc94..cca97a8ad0d6 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -4203,38 +4203,45 @@ endpoint_tests()
>  			$ns1 10.0.2.1 id 1 flags signal
>  		chk_subflow_nr "before delete" 2
>  		chk_mptcp_info subflows 1 subflows 1
> +		chk_mptcp_info add_addr_signal 2 add_addr_accepted 1
>  
>  		pm_nl_del_endpoint $ns1 1 10.0.2.1
>  		pm_nl_del_endpoint $ns1 2 224.0.0.1
>  		sleep 0.5
>  		chk_subflow_nr "after delete" 1
>  		chk_mptcp_info subflows 0 subflows 0
> +		chk_mptcp_info add_addr_signal 0 add_addr_accepted 0
>  
>  		pm_nl_add_endpoint $ns1 10.0.2.1 id 1 flags signal
>  		pm_nl_add_endpoint $ns1 10.0.3.1 id 2 flags signal
>  		wait_mpj $ns2
>  		chk_subflow_nr "after re-add" 3
>  		chk_mptcp_info subflows 2 subflows 2
> +		chk_mptcp_info add_addr_signal 2 add_addr_accepted 2
>  
>  		pm_nl_del_endpoint $ns1 42 10.0.1.1
>  		sleep 0.5
>  		chk_subflow_nr "after delete ID 0" 2
>  		chk_mptcp_info subflows 2 subflows 2
> +		chk_mptcp_info add_addr_signal 2 add_addr_accepted 2
>  
>  		pm_nl_add_endpoint $ns1 10.0.1.1 id 99 flags signal
>  		wait_mpj $ns2
>  		chk_subflow_nr "after re-add ID 0" 3
>  		chk_mptcp_info subflows 3 subflows 3
> +		chk_mptcp_info add_addr_signal 3 add_addr_accepted 2
>  
>  		pm_nl_del_endpoint $ns1 99 10.0.1.1
>  		sleep 0.5
>  		chk_subflow_nr "after re-delete ID 0" 2
>  		chk_mptcp_info subflows 2 subflows 2
> +		chk_mptcp_info add_addr_signal 2 add_addr_accepted 2
>  
>  		pm_nl_add_endpoint $ns1 10.0.1.1 id 88 flags signal
>  		wait_mpj $ns2
>  		chk_subflow_nr "after re-re-add ID 0" 3
>  		chk_mptcp_info subflows 3 subflows 3
> +		chk_mptcp_info add_addr_signal 3 add_addr_accepted 2
>  		mptcp_lib_kill_wait $tests_pid
>  
>  		kill_events_pids