Re: [PATCH mptcp-next v3 29/29] selftests: mptcp: add mptcp_lib_wait_local_port_listen

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 25/09/2023 10:42, Geliang Tang wrote:
> wait_local_port_listen() helper is defined in diag.sh, mptcp_connect.sh,
> mptcp_join.sh and simult_flows.sh, export it into mptcp_lib.sh and
> rename it with mptcp_lib_ prefix. Use this new helper in all these
> scripts.
> 
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
>  tools/testing/selftests/net/mptcp/diag.sh     | 23 +++----------------
>  .../selftests/net/mptcp/mptcp_connect.sh      | 19 +--------------
>  .../testing/selftests/net/mptcp/mptcp_join.sh | 20 +---------------
>  .../testing/selftests/net/mptcp/mptcp_lib.sh  | 18 +++++++++++++++
>  .../selftests/net/mptcp/simult_flows.sh       | 19 +--------------
>  5 files changed, 24 insertions(+), 75 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/selftests/net/mptcp/diag.sh
> index 85a8ee9395b3..95b498efacd1 100755
> --- a/tools/testing/selftests/net/mptcp/diag.sh
> +++ b/tools/testing/selftests/net/mptcp/diag.sh
> @@ -182,23 +182,6 @@ chk_msk_inuse()
>  	__chk_nr get_msk_inuse $expected "$msg" 0
>  }
>  
> -# $1: ns, $2: port
> -wait_local_port_listen()
> -{
> -	local listener_ns="${1}"
> -	local port="${2}"
> -
> -	local port_hex i
> -
> -	port_hex="$(printf "%04X" "${port}")"
> -	for i in $(seq 10); do
> -		ip netns exec "${listener_ns}" cat /proc/net/tcp | \

Here we were not looking at IPv6 (tcp6) but I guess that's OK because we
only have IPv4 connections here in diag.sh, right?)

Please mention that in the commit message to avoid further questions
from the reviewers when there are ambiguities that are not explained.

Other than that, it looks good to me!

Reviewed-by: Matthieu Baerts <matttbe@kernel.org>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net