Re: [PATCH mptcp-next 5/7] Add MPTCP support to ServerSocket class

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 23/07/2025 07:16, Geliang Tang wrote:
> This patch extends ServerSocket to support Multipath TCP (MPTCP) by:
> 
> 1. Adding a new constructor that accepts an mptcp parameter to enable
>    MPTCP
> 2. Introducing a new createImpl factory method that propagates the MPTCP
>    setting to the underlying socket implementation
> 3. Maintaining all existing functionality while adding MPTCP capabilities
> 
> The new constructor follows the same pattern as existing ServerSocket
> constructors but adds the mptcp parameter to control protocol selection.
> When enabled, the implementation uses the MPTCP-enabled socket creation
> path established in previous patches.

Similar to my comment in patch 2/7, I don't know what is best in this
project, but maybe instead of duplicating helpers, you could have the
previous helper calling the new extension?

So ServerSocket(int port, int backlog, InetAddress bindAddr) would call
the new one with 'mptcp' as new parameter? Same for createImpl()?

But not sure what the Java maintainers prefer. Maybe they are OK with
what you suggested.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.