Re: [PATCH RFC mptcp-next 1/4] mptcp: add a new sysctl scheduler

[Paolo Abeni <pabeni@redhat.com>]

Hi,

On Tue, 2021-09-07 at 18:41 +0800, Geliang Tang wrote:
> From: Geliang Tang <geliangtang@xiaomi.com>
> 
> This patch added a new sysctl, named scheduler, to support for selection
> of different schedulers.
> 
> Signed-off-by: Geliang Tang <geliangtang@xiaomi.com>
> ---
>  Documentation/networking/mptcp-sysctl.rst |  8 ++++++++
>  net/mptcp/ctrl.c                          | 14 ++++++++++++++
>  net/mptcp/protocol.h                      |  3 +++
>  3 files changed, 25 insertions(+)
> 
> diff --git a/Documentation/networking/mptcp-sysctl.rst b/Documentation/networking/mptcp-sysctl.rst
> index b0d4da71e68e..ecd593c44e26 100644
> --- a/Documentation/networking/mptcp-sysctl.rst
> +++ b/Documentation/networking/mptcp-sysctl.rst
> @@ -57,3 +57,11 @@ stale_loss_cnt - INTEGER
>  	This is a per-namespace sysctl.
>  
>  	Default: 4
> +
> +scheduler - STRING
> +	Select the scheduler of your choice.
> +
> +	Support for selection of different schedulers. This is a per-namespace
> +	sysctl.
> +
> +	Default: "default"
> diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c
> index 8b235468c88f..369369b0b17e 100644
> --- a/net/mptcp/ctrl.c
> +++ b/net/mptcp/ctrl.c
> @@ -26,6 +26,7 @@ struct mptcp_pernet {
>  	u8 mptcp_enabled;
>  	u8 checksum_enabled;
>  	u8 allow_join_initial_addr_port;
> +	char scheduler[MPTCP_SCHED_NAME_MAX];
>  };
>  
>  static struct mptcp_pernet *mptcp_get_pernet(const struct net *net)
> @@ -58,6 +59,11 @@ unsigned int mptcp_stale_loss_cnt(const struct net *net)
>  	return mptcp_get_pernet(net)->stale_loss_cnt;
>  }
>  
> +char *mptcp_get_scheduler(struct net *net)

I think it should returns 'const char *' and even the 'net' argument
should be const.

Cheers,

Paolo