From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BCE254B1C4 for ; Tue, 8 Sep 2026 17:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788889961; cv=none; b=nb0eN/o+NWxasdM9emccI2A9cr6J/yCq3IF1IjryjjIhH7a3Vh1lpcmzYg1tIa7yWMunTt+IWhubcQz2QztMB9SV9UdDK0XEVCZyu9OibdXkKheNYcR9kwBl3bIqdlpGxEUq9VlePHvM5RMjNDdbHafkFfw991onA8R9kLuEdug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788889961; c=relaxed/simple; bh=iqKBUdCdA7Xtvp98/kICJM6xtH7A5tdhoHIwe8fz1RE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=dfEl94dSEhJ9Zm4mLzG3NtHI9ELX1jTTsgf0f/JWOUxVoY95g9MD0v86gLPK+oBcYAzGvuS/J4o2do5vIqnuvrMxfMyWkzArxTV13EM8siavatAsxh+M8P2IwWC7Nrlw0jCncsQYKCUedCWP0H7Gf/+uaMbwrvWjC3HClJyBEpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JM40U+VQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JM40U+VQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DA3F1F00A3A; Tue, 8 Sep 2026 17:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788889959; bh=Ci3HvLRckiaSPwGcr86yeK5J2lOVOWcCEIONsL0RA50=; h=Date:Subject:To:References:From:In-Reply-To; b=JM40U+VQ8air9yv9asmaZjL9Gujhq00aHPSkIfwSOiQA/BNt/L95VhZMfh2YmVa12 W4Z4pWglt0faTY/700Eg5KAV8KG72D8O8+WndZkYpI8YuI4QPS3IW3ewGctaatvqgm xe5qnJw/c+yD9nPOvb7jvIkw2GKnjq35Emn7BIA4f+MO1s+lZZbtwBwjp/Qxbcw1Gh LCzp5miHCfwTkbzqvKEYfj5Z7AQi48FsZhIIZmOv4btan0U9WTa0jbckTwwCC/G5Wh fbGOU8L2CFixCAcHS3EIG0zPsSi3b02A6GXUfqUSCwRaGOV4BniljUvjw1bhpEzlsp EmXRD+c2jCQFg== Message-ID: <735a6655-b3ac-4352-8a35-0e54ac2c7ffd@kernel.org> Date: Tue, 8 Sep 2026 19:52:37 +0200 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next v3] selftests: mptcp: print stats before socket closure Content-Language: fr To: Geliang Tang , MPTCP Linux References: <20260815-sft-mptcp-stats-b4-close-v3-1-ccd9af14cf73@kernel.org> <24e7da3ea0b33d5dca970449cf615a4c95ecceb8.camel@kernel.org> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <24e7da3ea0b33d5dca970449cf615a4c95ecceb8.camel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Geliang, On 05/09/2026 10:26, Geliang Tang wrote: > Hi Matt, > > On Sat, 2026-08-15 at 00:28 +0200, Matthieu Baerts (NGI0) wrote: >> In case of poll timeout, it might be too late to print the stats >> after >> the socket closure. >> >> Now, in case of poll timeout, 'ss' and 'nstat' are invoked from >> mptcp_connect to print the stats before exiting. This should help >> debugging poll timeout issues. >> >> Note: for this "workaround", system() is used for debugging purposes > > This print_err_stats() implementation is basically the same as > mptcp_lib_pr_err_stats() in the shell, right? Correct. > I think it's better to use mptcp_lib_pr_err_stats() in the shell to > print the information. In mptcp_connect.c, when a poll timeout occurs, > we send a signal to the shell and don't close the socket immediately - > we wait for the shell to finish printing the information before closing > it. What do you think of this approach? There's a reference > implementation in the attachment, but I haven't tested it. Thank you for your review. I agree that what you suggested is better for a tool that would be used in production. But here with the selftests, I don't think we need your long patch with a higher complexity, just for the selftests. I think it is fine to have some "system()" calls with the same ss/nstat commands compared to a patch of 50+ lines to get the same result. No? Cheers, Matt -- Sponsored by the NGI0 Core fund.